-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover the hooks with tests #160
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
packages/react-components/src/Toast/toast_provider.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,112 @@ | ||
import React from 'react'; | ||
import { act, renderHook, screen } from '../test-utils'; | ||
|
||
import { ToastProvider } from './toast_provider'; | ||
import { useToast } from './use_toast'; | ||
|
||
const DURATION = 5000; | ||
|
||
const Provider = ({ children }: { children: React.ReactNode }) => ( | ||
<ToastProvider maxToasts={2}> | ||
{children} | ||
</ToastProvider> | ||
); | ||
|
||
jest.useFakeTimers(); | ||
|
||
describe('<ToastProvider />', () => { | ||
it('should render toast', () => { | ||
const { result } = renderHook(useToast, { wrapper: Provider }); | ||
const { addToast } = result.current; | ||
|
||
act(() => addToast({ message: 'Toast' })); | ||
|
||
expect(screen.queryByText('Toast')).toBeInTheDocument(); | ||
}); | ||
|
||
it('should unmount toast after expiration', () => { | ||
const { result } = renderHook(useToast, { wrapper: Provider }); | ||
const { addToast } = result.current; | ||
|
||
act(() => addToast({ message: 'Toast', duration: DURATION })); | ||
|
||
expect(screen.queryByText('Toast')).toBeInTheDocument(); | ||
|
||
act(() => jest.advanceTimersByTime(DURATION)); | ||
|
||
expect(screen.queryByText('Toast')).not.toBeInTheDocument(); | ||
}); | ||
|
||
it('should not render toast if toast with the same `id` is already in the state', () => { | ||
const { result } = renderHook(useToast, { wrapper: Provider }); | ||
const { addToast } = result.current; | ||
|
||
act(() => addToast({ id: '0', message: 'Toast-0' })); | ||
act(() => addToast({ id: '0', message: 'Toast-1' })); | ||
|
||
expect(screen.queryByText('Toast-1')).not.toBeInTheDocument(); | ||
}); | ||
|
||
it('should render the next toast in the queue after the first one expires', () => { | ||
const { result } = renderHook(useToast, { wrapper: Provider }); | ||
const { addToast } = result.current; | ||
|
||
act(() => addToast({ message: 'Toast-0', duration: 10 })); | ||
act(() => addToast({ message: 'Toast-1', duration: DURATION })); | ||
act(() => addToast({ message: 'Toast-2', duration: DURATION })); | ||
|
||
expect(screen.queryAllByText(/^Toast/)).toHaveLength(2); | ||
|
||
act(() => jest.advanceTimersByTime(10)); | ||
|
||
expect(screen.queryByText('Toast-1')).toBeInTheDocument(); | ||
expect(screen.queryByText('Toast-2')).toBeInTheDocument(); | ||
|
||
act(jest.runAllTimers); | ||
}); | ||
|
||
it('should render maximum `maxToasts` toasts', () => { | ||
const { result } = renderHook(useToast, { wrapper: Provider }); | ||
const { addToast } = result.current; | ||
|
||
act(() => addToast({ message: 'Toast-0' })); | ||
act(() => addToast({ message: 'Toast-1' })); | ||
act(() => addToast({ message: 'Toast-2' })); | ||
|
||
expect(screen.queryByText('Toast-0')).toBeInTheDocument(); | ||
expect(screen.queryByText('Toast-1')).toBeInTheDocument(); | ||
expect(screen.queryByText('Toast-2')).not.toBeInTheDocument(); | ||
}); | ||
|
||
it('should remove toast by id and render the next toast in the queue', () => { | ||
const { result } = renderHook(useToast, { wrapper: Provider }); | ||
const { addToast, removeToast } = result.current; | ||
|
||
act(() => addToast({ id: '0', message: 'Toast-0' })); | ||
act(() => addToast({ id: '1', message: 'Toast-1' })); | ||
act(() => addToast({ id: '2', message: 'Toast-2' })); | ||
|
||
expect(screen.queryByText('Toast-0')).toBeInTheDocument(); | ||
expect(screen.queryByText('Toast-1')).toBeInTheDocument(); | ||
expect(screen.queryByText('Toast-2')).not.toBeInTheDocument(); | ||
|
||
act(() => removeToast('0')); | ||
|
||
expect(screen.queryByText('Toast-0')).not.toBeInTheDocument(); | ||
expect(screen.queryByText('Toast-1')).toBeInTheDocument(); | ||
expect(screen.queryByText('Toast-2')).toBeInTheDocument(); | ||
}); | ||
|
||
it('should unmount and remove all toasts from queue', () => { | ||
const { result } = renderHook(useToast, { wrapper: Provider }); | ||
const { addToast, removeAllToasts } = result.current; | ||
|
||
for (let i = 0; i <= 5; i += 1) { | ||
act(() => addToast({ message: `Toast-${i}` })); | ||
} | ||
|
||
act(removeAllToasts); | ||
|
||
expect(screen.queryByText(/^Toast/)).not.toBeInTheDocument(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { useContext } from 'react'; | ||
|
||
import { renderHook } from '../test-utils'; | ||
import { useToast } from './use_toast'; | ||
import { ToastContext } from './toast_context'; | ||
|
||
describe('useToast()', () => { | ||
it('should return `ToastContext`', () => { | ||
const { result: result0 } = renderHook(useToast); | ||
const { result: result1 } = renderHook(() => useContext(ToastContext)); | ||
|
||
expect(result0).toEqual(result1); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import { act, renderHook } from '../test-utils'; | ||
import { useClipboard } from './use_clipboard'; | ||
import { copyToClipboard } from '../utils'; | ||
|
||
jest.useFakeTimers(); | ||
|
||
jest.mock('../utils', () => ({ | ||
copyToClipboard: jest.fn(), | ||
})); | ||
|
||
describe('useClipboard()', () => { | ||
afterEach(() => { | ||
jest.resetAllMocks(); | ||
}); | ||
|
||
it('should return `isCopied=true` on successfully copied', async () => { | ||
const { result } = renderHook(useClipboard); | ||
|
||
await act(() => result.current.copy('text_stub')); | ||
|
||
expect(copyToClipboard).toBeCalled(); | ||
expect(result.current.isCopied).toBe(true); | ||
}); | ||
|
||
it('should ignore an error that occurs during copying', async () => { | ||
const { result } = renderHook(useClipboard); | ||
|
||
jest.mock('../utils', () => ({ | ||
copyToClipboard: () => { | ||
throw new Error(); | ||
}, | ||
})); | ||
|
||
const copy = act(() => result.current.copy('text_stub')); | ||
|
||
await expect(copy).resolves.toBeUndefined(); | ||
}); | ||
|
||
it('should remain `isCopied=true` until the timeout expires and becomes `false` after', async () => { | ||
const { result, rerender } = renderHook(useClipboard); | ||
|
||
await act(() => result.current.copy('text_stub')); | ||
|
||
expect(result.current.isCopied).toBe(true); | ||
act(() => jest.advanceTimersByTime(1500)); | ||
rerender(); | ||
expect(result.current.isCopied).toBe(false); | ||
}); | ||
}); |
50 changes: 50 additions & 0 deletions
50
packages/react-components/src/hooks/use_controllable.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { act, renderHook } from '../test-utils'; | ||
import { useControllableState } from './use_controllable'; | ||
|
||
describe('useControllableState()', () => { | ||
it('should set default value and change state', () => { | ||
const { result, rerender } = renderHook(() => useControllableState({ | ||
defaultValue: 'default_value', | ||
})); | ||
|
||
expect(result.current[0]).toEqual('default_value'); | ||
|
||
act(() => result.current[1]('new_value')); | ||
rerender(); | ||
|
||
expect(result.current[0]).toEqual('new_value'); | ||
}); | ||
|
||
it('should call `onChange` on state update is `onChange` is passed', () => { | ||
const onChangeMock = jest.fn(); | ||
const { result } = renderHook(() => useControllableState({ | ||
onChange: onChangeMock, | ||
})); | ||
|
||
act(() => result.current[1]('new_value')); | ||
|
||
expect(onChangeMock).toBeCalled(); | ||
}); | ||
|
||
it('should do not update state if `shouldUpdate` is passed but not resolved', () => { | ||
const shouldUpdateMock = jest.fn().mockImplementationOnce(() => false); | ||
const { result } = renderHook(() => useControllableState({ | ||
shouldUpdate: shouldUpdateMock, | ||
})); | ||
|
||
act(() => result.current[1]('new_value')); | ||
|
||
expect(result.current[0]).toBeUndefined(); | ||
}); | ||
|
||
it('should update state if `shouldUpdate` is passed and resolved', () => { | ||
const shouldUpdateMock = jest.fn().mockImplementationOnce(() => true); | ||
const { result } = renderHook(() => useControllableState({ | ||
shouldUpdate: shouldUpdateMock, | ||
})); | ||
|
||
act(() => result.current[1]('new_value')); | ||
|
||
expect(result.current[0]).toEqual('new_value'); | ||
}); | ||
}); |
65 changes: 65 additions & 0 deletions
65
packages/react-components/src/hooks/use_debounce_callback.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
import { renderHook } from '../test-utils'; | ||
import { useDebounceCallback } from './use_debounce_callback'; | ||
|
||
jest.useFakeTimers(); | ||
|
||
const DEBOUNCE_TIMEOUT = 500; | ||
|
||
describe('useDebounceCallback()', () => { | ||
const clearTimeoutSpy = jest.spyOn(global, 'clearTimeout'); | ||
|
||
afterEach(() => { | ||
clearTimeoutSpy.mockClear(); | ||
}); | ||
|
||
it('should call the callback after timeout', () => { | ||
const callbackMock = jest.fn(); | ||
const { result } = renderHook(() => useDebounceCallback( | ||
callbackMock, | ||
DEBOUNCE_TIMEOUT, | ||
)); | ||
|
||
result.current(); | ||
expect(callbackMock).not.toBeCalled(); | ||
|
||
jest.advanceTimersByTime(DEBOUNCE_TIMEOUT); | ||
expect(callbackMock).toBeCalled(); | ||
}); | ||
|
||
it.only('should clear previous timer on the next debounced function call', () => { | ||
const setTimeoutSpy = jest.spyOn(global, 'setTimeout'); | ||
const callbackMock = jest.fn(); | ||
const { result } = renderHook(() => useDebounceCallback( | ||
callbackMock, | ||
DEBOUNCE_TIMEOUT, | ||
)); | ||
|
||
// Call timeout with callback on first call | ||
result.current(); | ||
expect(setTimeoutSpy).toBeCalled(); | ||
expect(callbackMock).not.toBeCalled(); | ||
|
||
// Clear previous callback timeout and set a new one on second call | ||
result.current(); | ||
expect(clearTimeoutSpy).toBeCalled(); | ||
expect(setTimeoutSpy).toBeCalled(); | ||
|
||
jest.advanceTimersByTime(DEBOUNCE_TIMEOUT); | ||
|
||
expect(callbackMock).toBeCalled(); | ||
}); | ||
|
||
it('should clear timer on unmount if `cleanUp=true', () => { | ||
const { result, unmount } = renderHook(() => useDebounceCallback( | ||
jest.fn(), | ||
DEBOUNCE_TIMEOUT, | ||
true, | ||
)); | ||
|
||
result.current(); | ||
|
||
unmount(); | ||
|
||
expect(clearTimeoutSpy).toBeCalled(); | ||
}); | ||
}); |
46 changes: 46 additions & 0 deletions
46
packages/react-components/src/hooks/use_event_callback.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import React from 'react'; | ||
|
||
import { | ||
render, | ||
renderHook, | ||
screen, | ||
fireEvent, | ||
} from '../test-utils'; | ||
import { useEventCallback } from './use_event_callback'; | ||
|
||
describe('useEventCallback()', () => { | ||
it('should do not call the callback during render', () => { | ||
const callbackMock = jest.fn(); | ||
const { result } = renderHook(() => useEventCallback(callbackMock)); | ||
|
||
render( | ||
// eslint-disable-next-line react/button-has-type | ||
<button onClick={result.current}>Button</button>, | ||
); | ||
|
||
expect(callbackMock).not.toBeCalled(); | ||
}); | ||
|
||
it('should call callback on event trigger', () => { | ||
const callbackMock = jest.fn(); | ||
const { result } = renderHook(() => useEventCallback(callbackMock)); | ||
|
||
render( | ||
// eslint-disable-next-line react/button-has-type | ||
<button onClick={result.current}>Button</button>, | ||
); | ||
|
||
fireEvent.click(screen.getByText('Button')); | ||
|
||
expect(callbackMock).toBeCalled(); | ||
}); | ||
|
||
it('should do not change callback reference on re-render', () => { | ||
const { result, rerender } = renderHook(() => useEventCallback(() => {})); | ||
const initialReference = result.current; | ||
|
||
rerender(); | ||
|
||
expect(initialReference).toEqual(result.current); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @dmytro587