Add pod spec to the CR #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyimo
reviewed
Jan 14, 2021
| @@ -19,8 +19,6 @@ spec: | |||
| replicas: 2 | |||
| template: | |||
| metadata: | |||
| annotations: | |||
There was a problem hiding this comment.
so how can we configure the manager annotations ?
cause we still needs to exclude it from the mesh in our cluster case
There was a problem hiding this comment.
The annotations will be managed through helm charts. If we need them in kind we will add when needed.
- Refactored the CR and pod creation to use a pod spec for Redis pods - Improved the waiting for pod creation - Removed the headless service - Removed option to toggle hugepages - Cleaned up unused kustomize configuration - Upgraded Golang version from 1.14 to 1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #55, closes #44, closes #54
Fixes the kustomize config issues from #50