Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pod creation check the Prometheus sidecar and init container #54

Closed
voltbit opened this issue Jan 11, 2021 · 0 comments · Fixed by #56
Closed

Make pod creation check the Prometheus sidecar and init container #54

voltbit opened this issue Jan 11, 2021 · 0 comments · Fixed by #56
Assignees
@voltbit
Milestone
Beta

Comments

@voltbit
Copy link
Contributor

voltbit commented Jan 11, 2021 •
edited
Loading

The operator does not wait for all containers to be ready, instead it waits for the pod to have an IP assigned. This causes errors in the controll flow - for example there will be an attempt to clusterize pods immediately after they have IPs, but the Redis container might not be up yet.
We should improve the logic here to take intro account the extra containers:

redis-operator/controllers/k8sresources.go

Line 256 in 568fe7b

followerPods, err := r.waitForPodNetworkInterface(followerPods...)

We should use health probes on the Redis container for this. (#40)
@voltbit voltbit added this to the Beta milestone Jan 11, 2021
@voltbit voltbit self-assigned this Jan 12, 2021
@voltbit voltbit mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voltbit voltbit

Labels
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Add pod spec to the CR
1 participant
@voltbit