-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace memoizee with a simpler alternative #152
Conversation
@kobik Any chance you could fast-track review for this? It's a blocking issue for us :-/ |
hey @kibertoad my man, have you used |
@kobik I did not, why? Can you recommend another minimalistic memoization solution? |
no, i haven't. just wondering whether to go with |
@kobik micro-memoize is 4 times larger and works 2 times slower according to benchmarks, but I'm OK with changing libraries if you recommend it. |
I can benchmark myself as well |
I don't have a strong opinion about either one of them. Just want to make sure it's working correctly. |
@kobik I'll write some tests. |
thanks @kibertoad |
@kobik Done! |
@kobik Could you please take a look? |
published |
Thank you! |
memoizee brings in 6 dependencies, that are completely irrelevant for
openapi-validator-middleware
use-case, as we are not using any expiration policy. This change makes the implementation more lambda-friendly and also helps when bundling with nexe.