[USB] Change endpoint0_setup argument type from uint64_t to setup_t #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
force-pushed
the
endpoint0_setup-arg
branch
from
21fb169
to
a6b3793
Compare
forderud
changed the title
This eliminates the need for converting between the types through the "bothwords" union member, which makes it a bit easier to follow the endpoint0_setup implementation. It also saves 64bit stack space, since the "setup_t setup" variable can be eliminated.
… use. The setup_t struct is a union, so the field removal won't affect the struct size.
forderud
force-pushed
the
endpoint0_setup-arg
branch
from
a6b3793
to
6775c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the need for converting between the types through the
bothwordsunion member, which makes it a bit easier to follow theendpoint0_setupimplementation. It also saves 64bit stack space, since thesetup_t setupvariable can be eliminated.