Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Time.h #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

borisneubert
Copy link

remove Time.h because it conflicts with time.h on file systems with case-insensitive filenames, e.g. Windows

remove Time.h because it conflicts with time.h on file systems with case-insensitive filenames, e.g. Windows
@vshymanskyy
Copy link

@PaulStoffregen this is a good idea

@PaulStoffregen
Copy link
Owner

PaulStoffregen commented Jul 16, 2018

@michaelmargolis - thoughts on this?

How about published books using Time.h vs TimeLib.h in example code?

@jamesmyatt
Copy link

This causes me lots of problems. If this sort of change cannot be made to this library for the benefit of lots of future users, then the only alternative may be forking it.

@PaulStoffregen
Copy link
Owner

PaulStoffregen commented Dec 5, 2018

I am currently working on a hardware project. No changes will happen with this library or any others I maintain until June 2019. Sorry, I need to pay the bills now (so I can do more open source stuff in the future). I've been burned many times before when making "trivial" changes to software without proper testing. Not going to do down the road again. Remind me about this next summer.

@borisneubert
Copy link
Author

@jamesmyatt For the time being you could use my fork

@PaulStoffregen
Copy link
Owner

@michaelmargolis - What is the situation with printed books in circulation? Will removing Time.h break examples? How much legacy from the old days are we facing?

@jamesmyatt
Copy link

This can finally be closed: b0cfc3c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants