Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to GET endpoint #164

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Updates to GET endpoint #164

merged 3 commits into from
Jul 31, 2024

Conversation

jvwong
Copy link
Member

@jvwong jvwong commented Jul 25, 2024 •
edited
Loading

Updates to the GET endpoint:

  • Use the Elasticsearch JS client get API rather than search
  • Test: Throws/rejects when GET fails to find document given ID
  • Web service: Forwards the HTTP 404 on Error

Refs #146

@jvwong jvwong requested a review from maxkfranz July 26, 2024 13:58
@maxkfranz maxkfranz merged commit 230f449 into master Jul 31, 2024
@jvwong jvwong deleted the iss146_not-found branch August 6, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkfranz maxkfranz Awaiting requested review from maxkfranz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvwong @maxkfranz