Fix kalandra's touch skipping mods #8323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kalandra's touch ignored item overrides causing the tooltip to only show stat difference when unequipping the copied ring. During filtering of mods an iterator was modified causing some mods to be skipped.
Paliak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8250
Description of the problem being solved:
When filtering out mods of type
SocketedInthe logic modified the table causing the iterator to get out of sync and skip mods.This pr additionally fixes an issue where Kalandra's touch was not taking item overrides into consideration showing stat difference only for the copied ring.
Link to a build that showcases this PR:
Before screenshot:
After screenshot: