Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rare templates #8229

Merged

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Aug 21, 2024

Update the rare item template file Rares.lua to sort the bases, and to update them to the newest base types introduced in 3.25

This was done based on this wiki page https://www.poewiki.net/wiki/Guide:Best_in_slot_base_types
with some minor differences
missing: Carnal Armour, Occultist's Vestment, many shields
extra: Archdemon Crown, and some heist shield bases

There is also 2 more questions/proposals, would we like to automatically check/set bases using an export script (which is how I did this update), this file has only been updated 4 times in 3 years, one of which is unrelated, two of which are fixing broken bases as GGG has changed them, and the last was adding magic flasks

And lastly, should any mods be updated (eg adding suppression to some evasion bases, or adding +gems/damage/spell crit es shields, adding abyss jewels/stygian belt, or adding common influenced/synth items)

@Paliak Paliak added the enhancement New feature, calculation, or mod label Aug 21, 2024
@LocalIdentity LocalIdentity merged commit 33da715 into PathOfBuildingCommunity:dev Sep 20, 2024
1 of 2 checks passed
@Regisle Regisle deleted the updateRareTemplates branch September 20, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants