Rework map mods and add Config tab multiList #8200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2024
Regisle
force-pushed
the
ConfigTabMultiList
branch
from
de566af
to
af5d96a
Compare
|
fixed controls to use the new packed rect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new type of config option,
multiListwhich is multiple dropdowns sharing a list in one of 2 ways, either with a fixed number of elements which are all shown (like this PR with maps), or with a variable number of dropdownsThese can have additional options added to them like sliders or number inputs for options which have more data to configure (like mod roll percentage, or curse level)
I will open up a few more PRs which use this multi list, its currently not an actual control becouse its pretty ingrained with the config tab functionality, but its possible if we want it in other places to make it its own control (the one other place where it would be useful is items tab which has its own multi list style control anyway)