New mob affixes #664
Open
New mob affixes #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think these should just be individual files tbh. I find these classes with multiple classes within it a bit hard to find sometimes.
There was a problem hiding this comment.
Alright, I was just following what had already been set up - DoubleLife was nested in a LifeAffixes class.
| { | ||
| public override bool PreAI(NPC npc) | ||
| { | ||
| if (npc.life < npc.lifeMax) |
There was a problem hiding this comment.
Shouldn't this be looking for half health? Doesn't look like it is
|
Good to re-review. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link Issues
Resolves: #659
Resolves: #658
Resolves: #657
Resolves: #656
Resolves: #655
Description of Work