Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SSTORE2MetadataProvider indexing #394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented May 20, 2024

Motivation

Solution

@0xble 0xble requested a review from arr00 May 20, 2024 16:45
Copy link

height bot commented May 20, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

Gas Report:
Accept Proposal: 31749
Create party custom metadata: 726170
Create party vanilla: 296856
Contribute to ETH party: 204946
Batch contribute two memberships to ETH party: 278336
Create proposal transfer eth: 141169
Execute proposal transfer eth: 123058
Create proposal distribute: 139523
Execute proposal distribute: 232549
Claim distribution: 74905

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.85%. Comparing base (8522dba) to head (a7a0cb0).

Files Patch % Lines
contracts/renderers/SSTORE2MetadataProvider.sol 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   70.87%   70.85%   -0.03%     
==========================================
  Files          71       71              
  Lines        3114     3115       +1     
  Branches      673      674       +1     
==========================================
  Hits         2207     2207              
  Misses        702      702              
- Partials      205      206       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants