Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new distributor #377

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: add new distributor #377

wants to merge 15 commits into from
+868 −2

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Feb 13, 2024 •
edited by arr00
Loading

Motivation

Solution

Link T-4299

@0xble 0xble requested a review from arr00 February 13, 2024 19:55
@height Height
Copy link

height bot commented Feb 13, 2024 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-4299" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@0xble 0xble marked this pull request as draft February 13, 2024 19:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.44%. Comparing base (136ed9b) to head (0befa6c).

Files Patch % Lines
contracts/proposals/ProposalExecutionEngine.sol 85.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   66.82%   67.44%   +0.61%     
==========================================
  Files          70       71       +1     
  Lines        2963     3010      +47     
  Branches      647      658      +11     
==========================================
+ Hits         1980     2030      +50     
+ Misses        783      779       -4     
- Partials      200      201       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

Gas Report:

@arr00 arr00 mentioned this pull request Feb 13, 2024
Closed
arr00
arr00 reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming along well. Some thoughts so far.

contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
@0xble 0xble marked this pull request as ready for review February 16, 2024 19:35
arr00
arr00 reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. A few comments

contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
contracts/distribution/PushDistributor.sol Outdated Show resolved Hide resolved
test/distribution/PushDistributor.t.sol Show resolved Hide resolved
arr00
arr00 approved these changes Feb 28, 2024
View reviewed changes
contracts/distribution/PushDistributor.sol
// Token address used to indicate ETH.
IERC20 private constant ETH_ADDRESS = IERC20(0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE);

function distribute(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like detailed natspec here. It's a pretty advanced function. Otherwise PR looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arr00 arr00 arr00 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xble @codecov-commenter @arr00