Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SellMembershipAuthority): remove outdated logic related to refunds #356

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Dec 4, 2023

NOTE: This does not require a re-deploy of SellMembershipAuthority. It behaves the same way but updates some comments and outdated and unnecessary logic when returning contribution amount to emit.

@0xble 0xble requested a review from arr00 December 4, 2023 17:51
Copy link

height bot commented Dec 4, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Dec 4, 2023

Gas Report:

@0xble
Copy link
Collaborator Author

0xble commented Dec 4, 2023

TODO: Fix tests

@arr00
Copy link
Contributor

arr00 commented Dec 4, 2023

This just went through an audit and changes provide no material benefits. I don't think this should be prioritized now.

@0xble
Copy link
Collaborator Author

0xble commented Dec 4, 2023

This just went through an audit and changes provide no material benefits. I don't think this should be prioritized now.

I actually didn't imagine we'd deploy this until the next significant change involving SellMembershipAuthority so yeah I kinda agree. I am concerned though that not updating in our remote repo will confuse people reading that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants