Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop flooding logs in FailureRateCircuitBreaker (#630) #633

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Stop flooding logs in FailureRateCircuitBreaker (#630) #633

merged 2 commits into from
Nov 1, 2023

Conversation

dvdstelt
Copy link
Member

@dvdstelt dvdstelt commented Nov 1, 2023 •
edited by ramonsmits
Loading

danielmarbach and others added 2 commits November 1, 2023 15:32
@danielmarbach @dvdstelt
Stop flooding logs in FailureRateCircuitBreaker (#630)
564769c 
* Make sure the failure rate circuit breaker only logs when there was actually a failure

* Cleanup dispose

* Rename to failures
@danielmarbach @dvdstelt
Properly release all the circuit breaker associated timers
fe80ac6 
Dispose circuit breakers
@dvdstelt dvdstelt added this to the 2.0.3 milestone Nov 1, 2023
@dvdstelt dvdstelt requested a review from ramonsmits November 1, 2023 14:35
@dvdstelt dvdstelt self-assigned this Nov 1, 2023
@dvdstelt dvdstelt merged commit b017fc7 into release-2.0 Nov 1, 2023
1 check passed
@dvdstelt dvdstelt deleted the log-flooding-backport branch November 1, 2023 23:13
@dvdstelt dvdstelt added the Bug label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonsmits ramonsmits ramonsmits approved these changes

Assignees

@dvdstelt dvdstelt

Labels
Bug
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dvdstelt @ramonsmits @danielmarbach