Support strong-named versions of MongoDB.Driver #658
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
.NET
dependabot
bot
force-pushed
the
dependabot/nuget/src/MongoDB.Driver-2.28.0
branch
3 times, most recently
from
24ba192 to
0c569b9
Compare
|
We're not alone in this https://jira.mongodb.org/browse/CSHARP-5206 |
dependabot
bot
force-pushed
the
dependabot/nuget/src/MongoDB.Driver-2.28.0
branch
2 times, most recently
from
a3a5376 to
39b7a31
Compare
|
Hi @johnsimons, Could I please request a review on this change. We've elaborated on this from the MongoDB side here but it would be super helpful to update this as versions from v2.28 and above will be Strong Named. Apologies for the inconvenience. Thanks, Rishit. |
|
I’m not comfortable with this change. The biggest issue is that is a critical breaking change requiring us to release a new major of the package. However, I believe this is the last of our concerns. By going down the path of incorporating a strong named assembly, it looks like our only option would be to stop using dependency ranges in the main package: my concern is that it’ll ripple on our users causing major headaches. Not to mention that it’ll force us to release a new version of the package for each release of the MongoDB client package. On top of that there will be the issue that users using more than one package depending on the MongoDB one won’t be to update until all dependencies update and release versions using the latest MongoDB client. |
|
Hi @mauroservienti, The ranges approach will still work with Strong naming as before, as long as all the versions within the range are all strong named (or all not strong named). As @rishitb-mongodb mentioned starting with 2.28 all MongoDB driver versions will be strong named, so it's safe to update to [2.28, 3.0.0). Few references:
|
Bumps [MongoDB.Driver](https://github.com/mongodb/mongo-csharp-driver) from 2.24.0 to 2.28.0. - [Release notes](https://github.com/mongodb/mongo-csharp-driver/releases) - [Commits](mongodb/mongo-csharp-driver@v2.24.0...v2.28.0) --- updated-dependencies: - dependency-name: MongoDB.Driver dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
cquirosj
force-pushed
the
dependabot/nuget/src/MongoDB.Driver-2.28.0
branch
from
7b16091 to
2ff29ca
Compare
cquirosj
changed the title
Fixes #660
Bumps MongoDB.Driver from 2.24.0 to 2.28.0.
Release notes
Sourced from MongoDB.Driver's releases.
... (truncated)
Commits
0d8134e2.28.0 Release notes (#1394)2ab2868CSHARP-5162: Continue to use FindExpressionProjectionDefinition to avoid regr...e0849deCSHARP-1276: Provide Strong-Named Assemblies (#1393)acbcd72CSHARP-5171: Adjust changes to driver conventions.d3a0baaCSHARP-5171: Add IReadOnlyDictionary to existing IDictionary indexer translat...74fba13CSHARP-4957: Fix issue with new array expression.46f39d5CSHARP-4017: Fix flaky Aggregate_with__out_includes_read_preference_for_5.0__...41e352eCSHARP-5181: Remove Serverless Proxy Incremental Rollout Tests (#1389)db235b7CSHARP-5180: Skip new tests on older servers.ce1a394CSHARP-5180: Support additional numeric conversions involving Nullable<T>.You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)