Use collection initializers (#1250)

Particular · Oct 11, 2023 · 0749f9c · 0749f9c
1 parent 7fc49f7
commit 0749f9c
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 16 deletions.
diff --git a/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_dispatching_messages.cs b/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_dispatching_messages.cs
@@ -69,14 +69,14 @@ public async Task Outgoing_operations_are_stored_atomically(Type contextProvider
         [Test]
         public void Proper_exception_is_thrown_if_queue_does_not_exist()
         {
-            var operation = new TransportOperation(new OutgoingMessage("1", new Dictionary<string, string>(), new byte[0]), new UnicastAddressTag("InvalidQueue"));
+            var operation = new TransportOperation(new OutgoingMessage("1", [], new byte[0]), new UnicastAddressTag("InvalidQueue"));
             Assert.That(async () => await dispatcher.Dispatch(new TransportOperations(operation), new TransportTransaction()), Throws.TypeOf<QueueNotFoundException>());
         }
 
         static TransportOperation CreateTransportOperation(string id, string destination, DispatchConsistency consistency)
         {
             return new TransportOperation(
-                new OutgoingMessage(id, new Dictionary<string, string>(), new byte[0]),
+                new OutgoingMessage(id, [], new byte[0]),
                 new UnicastAddressTag(destination),
                 requiredDispatchConsistency: consistency
                 );

diff --git a/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_message_receive_takes_long.cs b/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_message_receive_takes_long.cs
@@ -1,7 +1,6 @@
 namespace NServiceBus.Transport.SqlServer.IntegrationTests
 {
     using System;
-    using System.Collections.Generic;
     using System.Threading;
     using System.Threading.Tasks;
     using System.Transactions;
@@ -50,7 +49,7 @@ static async Task SendMessage(TableBasedQueue tableBasedQueue, SqlConnectionFact
                 using (var connection = await sqlConnectionFactory.OpenNewConnection(cancellationToken))
                 using (var tx = connection.BeginTransaction())
                 {
-                    var message = new OutgoingMessage(Guid.NewGuid().ToString(), new Dictionary<string, string>(), new byte[0]);
+                    var message = new OutgoingMessage(Guid.NewGuid().ToString(), [], new byte[0]);
                     await tableBasedQueue.Send(message, TimeSpan.MaxValue, connection, tx, cancellationToken);
                     tx.Commit();
                     scope.Complete();

diff --git a/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_recoverable_column_is_removed.cs b/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_recoverable_column_is_removed.cs
@@ -126,7 +126,7 @@ static IContextProvider CreateContext(Type contextType, SqlConnectionFactory sql
         static TransportOperation CreateTransportOperation(string id, string destination, DispatchConsistency consistency)
         {
             return new TransportOperation(
-                new OutgoingMessage(id, new Dictionary<string, string>(), new byte[0]),
+                new OutgoingMessage(id, [], new byte[0]),
                 new UnicastAddressTag(destination),
                 requiredDispatchConsistency: consistency
                 );

diff --git a/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_using_ttbr.cs b/src/NServiceBus.Transport.SqlServer.IntegrationTests/When_using_ttbr.cs
@@ -29,7 +29,7 @@ public async Task Defaults_to_no_ttbr()
                     context.Set(transportTransaction);
 
                     var operation = new TransportOperation(
-                        new OutgoingMessage("1", new Dictionary<string, string>(), new byte[0]),
+                        new OutgoingMessage("1", [], new byte[0]),
                         new UnicastAddressTag(ValidAddress)
                     );
 
@@ -91,7 +91,7 @@ public async Task Delivery_constraint_is_respected()
                     context.Set(transportTransaction);
 
                     var operation = new TransportOperation(
-                        new OutgoingMessage("1", new Dictionary<string, string>(), new byte[0]),
+                        new OutgoingMessage("1", [], new byte[0]),
                         new UnicastAddressTag(ValidAddress),
                         new DispatchProperties
                         {

diff --git a/src/NServiceBus.Transport.SqlServer.UnitTests/Sending/OperationSorterTests.cs b/src/NServiceBus.Transport.SqlServer.UnitTests/Sending/OperationSorterTests.cs
@@ -1,6 +1,5 @@
 namespace NServiceBus.Transport.SqlServer.UnitTests.Sending
 {
-    using System.Collections.Generic;
     using System.Linq;
     using NUnit.Framework;
     using Routing;
@@ -75,7 +74,7 @@ public void It_sorts_isolated_and_default_dispatch()
 
         static TransportOperation CreateTransportOperations(string messageId, string destination, DispatchConsistency dispatchConsistency = DispatchConsistency.Default)
         {
-            return new TransportOperation(new OutgoingMessage(messageId, new Dictionary<string, string>(), new byte[0]), new UnicastAddressTag(destination), requiredDispatchConsistency: dispatchConsistency);
+            return new TransportOperation(new OutgoingMessage(messageId, [], new byte[0]), new UnicastAddressTag(destination), requiredDispatchConsistency: dispatchConsistency);
         }
     }
 }
diff --git a/src/NServiceBus.Transport.SqlServer/Addressing/EndpointSchemaAndCatalogSettings.cs b/src/NServiceBus.Transport.SqlServer/Addressing/EndpointSchemaAndCatalogSettings.cs
@@ -42,7 +42,7 @@ Dictionary<string, string> GetProperties(string endpoint)
             return result;
         }
 
-        Dictionary<string, string> schemas = new Dictionary<string, string>();
-        Dictionary<string, string> catalogs = new Dictionary<string, string>();
+        Dictionary<string, string> schemas = [];
+        Dictionary<string, string> catalogs = [];
     }
 }
diff --git a/src/NServiceBus.Transport.SqlServer/Addressing/QueueSchemaAndCatalogOptions.cs b/src/NServiceBus.Transport.SqlServer/Addressing/QueueSchemaAndCatalogOptions.cs
@@ -31,7 +31,7 @@ internal void TryGet(string queueName, out string schema, out string catalog)
             catalogs.TryGetValue(queueName, out catalog);
         }
 
-        Dictionary<string, string> schemas = new Dictionary<string, string>();
-        Dictionary<string, string> catalogs = new Dictionary<string, string>();
+        Dictionary<string, string> schemas = [];
+        Dictionary<string, string> catalogs = [];
     }
 }
diff --git a/src/NServiceBus.Transport.SqlServer/Queuing/Message.cs b/src/NServiceBus.Transport.SqlServer/Queuing/Message.cs
@@ -22,7 +22,7 @@ public Message(string transportId, string originalHeaders, byte[] body, bool exp
         void InitializeHeaders()
         {
             var parsedHeaders = string.IsNullOrEmpty(originalHeaders)
-                ? new Dictionary<string, string>()
+                ? []
                 : DictionarySerializer.DeSerialize(originalHeaders);
 
             LegacyCallbacks.SubstituteReplyToWithCallbackQueueIfExists(parsedHeaders);

diff --git a/src/NServiceBus.Transport.SqlServer/Receiving/FailureInfoStorage.cs b/src/NServiceBus.Transport.SqlServer/Receiving/FailureInfoStorage.cs
@@ -72,7 +72,7 @@ public void ClearFailureInfoForMessage(string messageId)
             }
         }
 
-        Dictionary<string, FailureInfoNode> failureInfoPerMessage = new Dictionary<string, FailureInfoNode>();
+        Dictionary<string, FailureInfoNode> failureInfoPerMessage = [];
         LinkedList<string> leastRecentlyUsedMessages = new LinkedList<string>();
         object lockObject = new object();
 

diff --git a/src/NServiceBus.Transport.SqlServer/SqlServerTransportInfrastructure.cs b/src/NServiceBus.Transport.SqlServer/SqlServerTransportInfrastructure.cs
@@ -329,7 +329,7 @@ class FakePromotableResourceManager : IEnlistmentNotification
         ConnectionAttributes connectionAttributes;
         QueueAddressTranslator addressTranslator;
         DueDelayedMessageProcessor dueDelayedMessageProcessor;
-        Dictionary<string, object> diagnostics = new Dictionary<string, object>();
+        Dictionary<string, object> diagnostics = [];
         SqlConnectionFactory connectionFactory;
         ISubscriptionStore subscriptionStore;
         IDelayedMessageStore delayedMessageStore = new SendOnlyDelayedMessageStore();