Prevent header dictionary resize & span based overloads #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
headers-resize
branch
from
49d9717 to
a97b63a
Compare
danielmarbach
commented
May 4, 2024
|
Ping @bording |
bording
reviewed
May 10, 2024
src/NServiceBus.Transport.RabbitMQ/Receiving/MessageConverter.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Transport.RabbitMQ/Receiving/MessageConverter.cs
Outdated
Show resolved
Hide resolved
bording
reviewed
May 10, 2024
src/NServiceBus.Transport.RabbitMQ/Receiving/MessageConverter.cs
Outdated
Show resolved
Hide resolved
danielmarbach
force-pushed
the
headers-resize
branch
from
f531f7f to
4b9f244
Compare
danielmarbach
force-pushed
the
headers-resize
branch
from
4b9f244 to
4df0c6b
Compare
|
@bording have you had a chance to give this some thought? |
bording
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message converter resizing in SC accounts for 20% of the allocation for header dictionaries
Before
After