Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade solidity to 0.4.23 #55

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

luisfidelis
Copy link

resolves #51

@luisfidelis
Copy link
Author

luisfidelis commented Jun 1, 2018

  • Upgrade Truffle to 4.1.7 (solc 0.4.23)
  • Upgrade and rename zeppelin-solidity to [email protected]
  • Use constructor() to define contract's constructor
  • Add emit keyword when logging events
  • Use view and pure instead of constant (will be deprecated)
  • Add public visibility in some functions to avoid compilation warnings

@luisfidelis
Copy link
Author

I need more details about those errors from paratii-js reported on #51

@jellegerbrandy
Copy link
Contributor

Thank you very much, Luis, for this PR. It looks really good.

I'll comment on #51 on how to reproduce the errors.

@luisfidelis
Copy link
Author

@jellegerbrandy i've commented on #51 on how to fix paratii-js tests errors regarding solidity 0.4.23/24. Tested with a reference to github:luisfidelis/paratii-contracts#aa8a3dd59cfe51f0d9dfff313d7b49c6fdcd8c43, the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade truffle
2 participants