add custom RQ job class capability with --job-class #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello! This PR adds the job class capability to
rq-dashboard
. Please let me know what additional sort of unit tests you'd expect to see; I've formatted with isort and black and ensured pytest and flake8 are passing.For my company's internal implementation of RQ we use a custom job class as described here:
https://python-rq.org/docs/workers/#worker-arguments
The way the RQ API works, you essentially need to pass this every time you construct an object (there's no global variable for this).
Also, not every function in RQ is capable of respecting this setting. In particular, rq-dashboard uses
requeue_job
which is incapable of respecting the setting so I replaced it's usage.This PR would add the capability to specify this according to what I perceive to be the pattern in the repo. Internally, RQ accepts this parameter as a string -
rq-dashboard
would too, if this is accepted, which I think is the simplest way to specify it for the operator.