Skip to content

perf: more use of raw strings and slices #186

perf: more use of raw strings and slices

perf: more use of raw strings and slices #186

Triggered via push February 2, 2024 11:41
Status Failure
Total duration 36s
Artifacts

build.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 4 warnings
mismatched types: src/sources/modrinth.rs#L251
error[E0308]: mismatched types --> src/sources/modrinth.rs:251:62 | 251 | .filter(|v| is_proxy || v.game_versions.contains(mcver)) | -------- ^^^^^ expected `&String`, found `&str` | | | arguments to this method are incorrect | = note: expected reference `&std::string::String` found reference `&str` note: method defined here --> /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/slice/mod.rs:2579:12
mismatched types: src/sources/hangar.rs#L80
error[E0308]: mismatched types --> src/sources/hangar.rs:80:22 | 80 | Some(self.0.mc_version()) | ---- ^^^^^^^^^^^^^^^^^^^- help: try using a conversion method: `.to_string()` | | | | | expected `String`, found `&str` | arguments to this enum variant are incorrect | help: the type constructed contains `&str` due to the type of the argument passed --> src/sources/hangar.rs:80:17 | 80 | Some(self.0.mc_version()) | ^^^^^-------------------^ | | | this argument influences the type of `Some` note: tuple variant defined here --> /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/option.rs:577:5
mismatched types: src/app/from_string.rs#L419
error[E0308]: mismatched types --> src/app/from_string.rs:419:29 | 419 | / ... self.prompt_string_filled( 420 | | ... "Artifact?", 421 | | ... if urlstr.starts_with(&suggest) { 422 | | ... urlstr ... | 430 | | ... }, 431 | | ... ) | |_______________________^ expected `String`, found `Result<String, Error>` | = note: expected struct `std::string::String` found enum `std::result::Result<std::string::String, anyhow::Error>` help: consider using `Result::expect` to unwrap the `std::result::Result<std::string::String, anyhow::Error>` value, panicking if the value is a `Result::Err` | 431 | ).expect("REASON") | +++++++++++++++++
clippy
Clippy had exited with the 101 exit code
build (ubuntu-latest)
Process completed with exit code 101.
build (windows-latest)
The operation was canceled.
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.