Skip to content

cargo fmt

cargo fmt #106

Triggered via push November 18, 2023 18:47
Status Failure
Total duration 3m 18s
Artifacts 2

build.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 5 warnings
useless use of `format!`: src/core/worlds.rs#L91
error: useless use of `format!` --> src/core/worlds.rs:91:26 | 91 | .context(format!("Processing datapacks"))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Processing datapacks".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
useless use of `format!`: src/core/worlds.rs#L81
error: useless use of `format!` --> src/core/worlds.rs:81:45 | 81 | spinner.finish_with_message(format!("Unzipped world successfully")); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unzipped world successfully".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format note: the lint level is defined here --> src/main.rs:1:9 | 1 | #![deny(clippy::all)] | ^^^^^^^^^^^ = note: `#[deny(clippy::useless_format)]` implied by `#[deny(clippy::all)]`
clippy
Clippy had exited with the 101 exit code
useless use of `format!`: src/core/worlds.rs#L91
error: useless use of `format!` --> src/core/worlds.rs:91:26 | 91 | .context(format!("Processing datapacks"))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Processing datapacks".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
useless use of `format!`: src/core/worlds.rs#L81
error: useless use of `format!` --> src/core/worlds.rs:81:45 | 81 | spinner.finish_with_message(format!("Unzipped world successfully")); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unzipped world successfully".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format note: the lint level is defined here --> src/main.rs:1:9 | 1 | #![deny(clippy::all)] | ^^^^^^^^^^^ = note: `#[deny(clippy::useless_format)]` implied by `#[deny(clippy::all)]`
this function has too many lines (101/100): src/interop/markdown.rs#L229
warning: this function has too many lines (101/100) --> src/interop/markdown.rs:229:5 | 229 | / pub async fn fetch_downloadable_info( 230 | | &self, 231 | | dl: &Downloadable, 232 | | ) -> Result<IndexMap<String, String>> { ... | 345 | | Ok(map) 346 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines = note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`
consider adding a `;` to the last statement for consistent formatting: src/hot_reload/mod.rs#L400
warning: consider adding a `;` to the last statement for consistent formatting --> src/hot_reload/mod.rs:400:33 | 400 | / ... println!( 401 | | ... "{} '{}' does not exist! Can't upload log.", 402 | | ... ColorfulTheme::default().error_prefix, 403 | | ... style(latest_log_path.to_string_lossy()).dim() 404 | | ... ) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned note: the lint level is defined here --> src/main.rs:2:9 | 2 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]` help: add a `;` here | 400 ~ println!( 401 + "{} '{}' does not exist! Can't upload log.", 402 + ColorfulTheme::default().error_prefix, 403 + style(latest_log_path.to_string_lossy()).dim() 404 + ); |
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
this function has too many lines (101/100): src/interop/markdown.rs#L229
warning: this function has too many lines (101/100) --> src/interop/markdown.rs:229:5 | 229 | / pub async fn fetch_downloadable_info( 230 | | &self, 231 | | dl: &Downloadable, 232 | | ) -> Result<IndexMap<String, String>> { ... | 345 | | Ok(map) 346 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines = note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`
consider adding a `;` to the last statement for consistent formatting: src/hot_reload/mod.rs#L400
warning: consider adding a `;` to the last statement for consistent formatting --> src/hot_reload/mod.rs:400:33 | 400 | / ... println!( 401 | | ... "{} '{}' does not exist! Can't upload log.", 402 | | ... ColorfulTheme::default().error_prefix, 403 | | ... style(latest_log_path.to_string_lossy()).dim() 404 | | ... ) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned note: the lint level is defined here --> src/main.rs:2:9 | 2 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]` help: add a `;` here | 400 ~ println!( 401 + "{} '{}' does not exist! Can't upload log.", 402 + ColorfulTheme::default().error_prefix, 403 + style(latest_log_path.to_string_lossy()).dim() 404 + ); |

Artifacts

Produced during runtime
Name Size
mcman-ubuntu-latest Expired
7.96 MB
mcman-windows-latest Expired
9.21 MB