(Yakuake) Fix black squares at rounded edges #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorsoen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the black artifacts near the rounded edges of both light and dark versions of the theme :
This uses a pretty gross hack, consisting of setting the shadow's ending opacity to 1 percent instead of zero.
There's no noticable changes to my eye (except for the now gone black edges) but feedback on other setups is welcome :
This bug happened to me on Plasma 6.1.5 with Intel graphics.
I am not aware if it could be fixed by porting the theme to Plasma 6, or by using different drivers.
Assuming it's gonna take a while only to receive feedback on this, porting is not gonna happen in a while or ever, thus the aformentionned hack 😅