Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma 6 support #145

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

principis
Copy link

@principis principis commented Mar 18, 2024

As of Plasma 6 all themes are now handled as kpackage, which means that a manifest.json file is required.

This PR ports the metadata.desktop files to metadata.json. This supports both Plasma 5 and Plasma 6.

FYI: this PR is backported in Fedora 40.

@principis
Copy link
Author

principis commented Mar 26, 2024

The switch.svg widget is broken in Plasma 6, and I don't know how to fix it, so I removed it. It falls back to the default widget which looks fine.

@ItachiSan
Copy link

There are a few more metadata.desktop files, do they not need conversion too?
Was just experimenting converting them locally with desktoptojson

@principis
Copy link
Author

principis commented Apr 5, 2024

I don't think so, at least not for plasma theming. Please point me to the relevant documentation (if it exists...), and I'll be happy to migrate them.

A plain .desktop to .json is not recommended, as there are the packaging format changes, not just the file format.

Otherwise the wallpapers will not appear in the background view.
@principis
Copy link
Author

Converted the wallpapers as well. Otherwise they wouldn't show up in the wallpaper view.

I believe @ItachiSan was right, and everything needs to be converted. There are still a few .desktop files left, but I haven't encountered them yet. If anyone knows where the issue occurs, please let me know where so that I can port and test it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants