Compile runtime on linux #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDL_config.h header dictates the selected configuration for the SDL library. This normally does not affect consuming libraries as the configuration normally switches on/off certain implementation details. In this case the header SDL_syswm.h was using said configuration for including the windows.h header (wich as you might imagine is not available on non window splatforms.
|
The compilation error is generated because the wrong video driver is defined on the windows build. Myabe doing a |
|
Thank you for trying to do this, I'll get back to you soon 😄 |
…ate SDL_Config. as needed
|
I took care of the issue. Can you please re-generate the project files and ensure that the runtime still compiles for Linux? |
|
The path was case insensitive, causing the function to fail on linux (fixed on the latest commit. Sorry for the wrong naming on the commits, is there any guide on what subsystem names to put? |
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the runtime of the game engine gets compiled in linux.
The most important change is the "modification" of the SDL library configuration. IMO this is a hint on that the approach of including the library and headers falls apart when trying to port the engine into different platforms.
#66