Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle-ES consistency #240
Oracle-ES consistency #240
Changes from 4 commits
9903938
42d55b3
f27f278
af9f212
4c560a6
2296f6d
b8a2ab1
acfe45a
e39efe2
8a71791
90380a9
7bac202
12dd86e
944b5a2
26a1dfe
20875b1
46cf0af
72d85a9
cacba11
4d8eb83
181fb14
7117242
165c5d2
8f84d22
d195650
612bf52
01ae258
8f86ddd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for information: this check would cause
AuthorizationException
in case of remote connection via Nginx proxy:I updated proxy configuration to allow
HEAD
requests (to readable locations), as there`s no actual need to block them; so now there should be no problem with it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And (again, just for information), there was another way to hit the goal:
Even with
NotFoundError
it is possible to say one situation from another:And in case of the error -- or, maybe, even in case of any error, when
info['error']
is defined (but I am not sure if there can possibly be any other error) -- re-raise the exception to indicate that the process can not be continued. Maybe wrapping the exception intoDataflowException
.The only situation when it makes any difference is when during the process execution the index was removed or access policy changed: the check was successfully passed on the start, so any
NotFoundError
after this will be taken as "record missed", no matter what. But I don`t think it is likely to happen, so there`s nothing wrong in the one-time check.