Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frozen] pyDKB.dataflow.stage tests #196

Open
wants to merge 28 commits into
base: pyDKB
Choose a base branch
from
Open

[frozen] pyDKB.dataflow.stage tests #196

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4c1c44a
Added command line arguments tests.
Evildoor Nov 16, 2018
e1343c5
Updated a check_args method.
Evildoor Nov 19, 2018
1022253
Reworked mode tests.
Evildoor Nov 19, 2018
088e180
Added testing for arguments' interactions.
Evildoor Nov 19, 2018
339c3ca
Improved check_args method.
Evildoor Nov 20, 2018
1a56cd0
Removed unnecesary redefinition.
Evildoor Nov 20, 2018
dcbdeab
Reworked modes handling.
Evildoor Nov 20, 2018
3eaa413
Added long versions for eop and eom testing.
Evildoor Nov 20, 2018
1565684
Improved consistency: short version before long.
Evildoor Nov 20, 2018
be922c9
Added input files test.
Evildoor Nov 20, 2018
aa90f7c
Removed short version of override tests.
Evildoor Nov 20, 2018
cf56b0c
Moved override_hdfs_mode definition into a loop.
Evildoor Nov 20, 2018
8a37c7d
Improved readability in testing hdfs overrides.
Evildoor Nov 21, 2018
324978c
Moved repeating args definition into setUp().
Evildoor Nov 23, 2018
fdb498a
Added tests for config argument.
Evildoor Dec 14, 2018
42877e2
Improved config tests.
Evildoor Dec 17, 2018
9dc9aa0
Added 'incorrect' tests for mode, source and dest.
Evildoor Dec 18, 2018
19ca409
Improved the functions with 'short' argument.
Evildoor Dec 20, 2018
c3e4810
Updated tests for correct config.
Evildoor Jan 23, 2019
c81a096
Merge remote-tracking branch 'origin/pyDKB' into pyDKB-tests
Evildoor Apr 24, 2019
f795e24
Adapt tests to pyDKB changes.
Evildoor Apr 26, 2019
77ef71b
Add empty EOM tests.
Evildoor Apr 29, 2019
1d4feb2
Change value used to trigger an error.
Evildoor Apr 29, 2019
b5d6842
Rename a variable to improve readability.
Evildoor Apr 29, 2019
38a383e
Add raw strings processing test.
Evildoor Apr 29, 2019
c99f4c6
Replace repeating assignments with dict.update().
Evildoor Apr 29, 2019
e1df893
Add missing return value description.
Evildoor Apr 29, 2019
7dad261
Divide test_ProcessorStage.py per how-to: tests.
Evildoor Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 46 additions & 58 deletions Utils/Dataflow/pyDKB/dataflow/stage/tests/test_ProcessorStage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,81 +55,74 @@ class ProcessorStageArgsTestCase(unittest.TestCase):

def setUp(self):
self.stage = pyDKB.dataflow.stage.ProcessorStage()
self.args = dict(self.default_args)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe name it expected_args (or exp_args)? Longer, right, but more readable... it`s just now it makes me remid myself every now and then how it is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


def tearDown(self):
self.stage = None
self.args = None

def check_args(self, args):
for a in args:
def check_args(self):
for a in self.args:
# Such kind of testing does not display the argument's name,
# hence the {a: ...} addition.
self.assertEqual({a: getattr(self.stage.ARGS, a)}, {a: args[a]})
self.assertEqual({a: getattr(self.stage.ARGS, a)},
{a: self.args[a]})

def test_default(self):
self.stage.parse_args('')
self.check_args(self.default_args)
self.check_args()

def test_hdfs(self):
self.stage.parse_args(['--hdfs'])
args = dict(self.default_args)
args['hdfs'] = True
args['source'] = 'h'
args['dest'] = 'h'
self.check_args(args)
self.args['hdfs'] = True
self.args['source'] = 'h'
self.args['dest'] = 'h'
self.check_args()

def test_e(self):
self.stage.parse_args(['-e', '\t'])
args = dict(self.default_args)
args['eom'] = '\t'
self.check_args(args)
self.args['eom'] = '\t'
self.check_args()

def test_end_of_message(self):
self.stage.parse_args(['--end-of-message', '\t'])
args = dict(self.default_args)
args['eom'] = '\t'
self.check_args(args)
self.args['eom'] = '\t'
self.check_args()

def test_E(self):
self.stage.parse_args(['-E', '\t'])
args = dict(self.default_args)
args['eop'] = '\t'
self.check_args(args)
self.args['eop'] = '\t'
self.check_args()

def test_end_of_process(self):
self.stage.parse_args(['--end-of-process', '\t'])
args = dict(self.default_args)
args['eop'] = '\t'
self.check_args(args)
self.args['eop'] = '\t'
self.check_args()

def test_i(self):
self.stage.parse_args(['-i', 'something'])
args = dict(self.default_args)
args['input_dir'] = 'something'
self.check_args(args)
self.args['input_dir'] = 'something'
self.check_args()

def test_input_dir(self):
self.stage.parse_args(['--input-dir', 'something'])
args = dict(self.default_args)
args['input_dir'] = 'something'
self.check_args(args)
self.args['input_dir'] = 'something'
self.check_args()

def test_o(self):
self.stage.parse_args(['-o', 'something'])
args = dict(self.default_args)
args['output_dir'] = 'something'
self.check_args(args)
self.args['output_dir'] = 'something'
self.check_args()

def test_output_dir(self):
self.stage.parse_args(['--output-dir', 'something'])
args = dict(self.default_args)
args['output_dir'] = 'something'
self.check_args(args)
self.args['output_dir'] = 'something'
self.check_args()

def test_input_files(self):
self.stage.parse_args(['something', 'something_else'])
args = dict(self.default_args)
args['input_files'] = ['something', 'something_else']
self.check_args(args)
self.args['input_files'] = ['something', 'something_else']
self.check_args()


def add_arg(arg, val, short=False):
Expand All @@ -138,9 +131,8 @@ def f(self):
self.stage.parse_args(['-' + arg[0], val])
else:
self.stage.parse_args(['--' + arg, val])
args = dict(self.default_args)
args[arg] = val
self.check_args(args)
self.args[arg] = val
self.check_args()
if short:
setattr(ProcessorStageArgsTestCase, 'test_%s_%s' % (arg[0], val), f)
else:
Expand All @@ -153,9 +145,8 @@ def f(self):
self.stage.parse_args(['-m', val])
else:
self.stage.parse_args(['--mode', val])
args = dict(self.default_args)
args.update(modes[val])
self.check_args(args)
self.args.update(modes[val])
self.check_args()
if short:
setattr(ProcessorStageArgsTestCase, 'test_m_%s' % (val), f)
else:
Expand All @@ -166,36 +157,33 @@ def f(self):
def add_override_hdfs(arg, val):
def f(self):
self.stage.parse_args(['--hdfs', '--' + arg, val])
args = dict(self.default_args)
args[arg] = val
args['hdfs'] = True
args['source'] = 'h'
args['dest'] = 'h'
self.check_args(args)
self.args[arg] = val
self.args['hdfs'] = True
self.args['source'] = 'h'
self.args['dest'] = 'h'
self.check_args()
setattr(ProcessorStageArgsTestCase,
'test_override_hdfs_%s_%s' % (arg, val), f)


def add_override_mode(arg, val, mode_val):
def f(self):
self.stage.parse_args(['--' + arg, val, '--mode', mode_val])
args = dict(self.default_args)
args.update(modes[mode_val])
args[arg] = val
self.check_args(args)
self.args.update(modes[mode_val])
self.args[arg] = val
self.check_args()
setattr(ProcessorStageArgsTestCase,
'test_override_%s_%s_mode_%s' % (arg, val, mode_val), f)


def add_override_hdfs_mode(val):
def f(self):
self.stage.parse_args(['--hdfs', '--mode', val])
args = dict(self.default_args)
args.update(modes[val])
args['hdfs'] = True
args['source'] = 'h'
args['dest'] = 'h'
self.check_args(args)
self.args.update(modes[val])
self.args['hdfs'] = True
self.args['source'] = 'h'
self.args['dest'] = 'h'
self.check_args()
setattr(ProcessorStageArgsTestCase,
'test_override_hdfs_mode_%s' % (val), f)

Expand Down