Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module/lb_internal): Adding IPv6 support to the module #41

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

pavelrn
Copy link
Contributor

@pavelrn pavelrn commented Sep 13, 2024

Description

  • Add ip_version parameter to select IPV4 or IPV6.
  • Add support for IPv6 google_compute_forwarding_rule.
  • Set google_compute_region_backend_service balancing_mode = "CONNECTION" explicitly due to the change in the terraform-provider-google version 6.0+

Motivation and Context

IPv6 might used for connectivity in the enterprise network. Because VM-Series is a part of the network, the deployment must support IPv6.

Closes #40.

How Has This Been Tested?

Create a load balancer as part of Common architecture.

Screenshots (if appropriate)

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@pavelrn pavelrn added bug Something isn't working enhancement New feature or request labels Sep 13, 2024
@pavelrn pavelrn self-assigned this Sep 13, 2024
@pavelrn pavelrn requested a review from a team as a code owner September 13, 2024 09:51
@pavelrn pavelrn linked an issue Sep 13, 2024 that may be closed by this pull request
@pavelrn pavelrn force-pushed the feature/ipv6-lb-internal branch from c04bb40 to d22a87c Compare September 18, 2024 12:32
modules/lb_internal/variables.tf Show resolved Hide resolved
modules/lb_internal/variables.tf Show resolved Hide resolved
@pavelrn pavelrn merged commit 0673ed6 into main Sep 18, 2024
35 checks passed
@pavelrn pavelrn deleted the feature/ipv6-lb-internal branch September 18, 2024 14:24
@pavelrn pavelrn restored the feature/ipv6-lb-internal branch September 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IPv6 support to the lb_internal module
2 participants