Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding ability to enable instance monitoring #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: adding ability to enable instance monitoring #77

wants to merge 2 commits into from

Conversation

ntwrkguru
Copy link
Contributor

Description

Motivation and Context

Expose the provider's ability to enable instance monitoring. Prior to this PR it is hardcoded to false.

How Has This Been Tested?

local

Screenshots (if appropriate)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@ntwrkguru ntwrkguru requested a review from a team as a code owner August 29, 2024 20:00
sebastianczech
sebastianczech approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@sebastianczech sebastianczech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍
Do you want to add similar feature for panorama module ?

terraform-aws-swfw-modules/modules/panorama/main.tf

Line 44 in 3c1e010

monitoring = false

@github-actions github-actions bot added the stale label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianczech sebastianczech sebastianczech approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntwrkguru @sebastianczech