feat: Render service.go for entry and config
#42
Conversation
…d functions used in templates
… the issues from `golangci-lint run --enable-all`
…hich from now is used also in config.tmpl
sebastianczech
force-pushed
the
render-service
branch
from
491b5e3 to
ec3c02e
Compare
templates/sdk/service.tmpl
Outdated
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "github.com/PaloAltoNetworks/pango/errors" | ||
| "github.com/PaloAltoNetworks/pango/filtering" | ||
| "github.com/PaloAltoNetworks/pango/util" | ||
| "github.com/PaloAltoNetworks/pango/xmlapi" | ||
| ) |
There was a problem hiding this comment.
Don't statically define imports, just use the importlib helper. Firstly because that's why it exists, and second because even pango will eventually need to import other libs (think subconfig). So let the importlib help with that.
./pkg/imports/manager.go
There was a problem hiding this comment.
I used imports manager:
Now that list is static for every template:
but when I start working with more advanced objects, which are using other objects - I need to import them, so I will extend that logic in other PRs.
| package {{packageName .GoSdkPath}} | ||
| {{- if .Entry}} |
There was a problem hiding this comment.
Entry style normalizations and Config style normalizations should probably be separate files.
This becomes more apparent now that we need to add support for UUID-Entry styled services.
There was a problem hiding this comment.
At this moment I propose to leave it as it's - in next stages, when I start work on UUID, I can split it. If we will have other template for that login for configs, what should be the output file name , if service.go is going to be reserved for entries ?
There was a problem hiding this comment.
It would still be service.go because it's the service for that namespace. Just the contents of the service is different.
There was a problem hiding this comment.
Now from the name of the template , we are creating final file:
pan-os-codegen/pkg/generate/generator.go
Line 77 in 03809ff
so from service.tmpl we are creating service.go.
If we want to split it to different templates, but receive file service.go, then I need to rebuild that logic - I propose to do it in other PR, ok?
There was a problem hiding this comment.
Hmm, then I wouldn't wrap the entirety of the file in an if/else, then. There are not a ton of changes between an Entry service.go and a Config service.go. Be more specific with the template instead of splitting it into separate template files.
| package {{packageName .GoSdkPath}} | ||
| {{- if .Entry}} |
There was a problem hiding this comment.
It would still be service.go because it's the service for that namespace. Just the contents of the service is different.
Description
PR delivers mainly new template used to render
service.gofor entry and configMotivation and Context
#32
How Has This Been Tested?
Template was checked locally by generating code from the template and trying to created, update and delete:
New function is tested via unit test.
Types of changes
Checklist