Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Copy static files (assets) #29

Merged
merged 28 commits into from
Mar 8, 2024
Merged

feat: Copy static files (assets) #29

merged 28 commits into from
Mar 8, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Mar 6, 2024 •
edited
Loading

Description

PR delivers functions to copy static files (assets) into generated code.

Motivation and Context

#28

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech
new function to make indentation equal in list of strings
2155e70
@sebastianczech
execute new function creating definition of structs
d5ffed6
@sebastianczech
new function creating definition of structs (with tests)
dcb8f2e
@sebastianczech
fix logic after tests
7c5f19b
@sebastianczech
refactor code (remove duplication and extract func)
8171827
@sebastianczech
fix random order in keys for maps
7aad155
@sebastianczech
update testify package
b2bef13
@sebastianczech
new functions to generate functions for locations
cd267f2
@sebastianczech
use new functions for locations
e975329
@sebastianczech
extend template, do not concat strings to generate structs
b5095ac
@sebastianczech
extend template, do not concat strings to generate functions
a07ae67
@sebastianczech
clean code
2b7514c
@sebastianczech
tests for functions used while generating structs and funcs
5bc88c5
@sebastianczech
fix issues after tests
d9fdd83
@sebastianczech
remove not required spaces from templates
f1f2525
@sebastianczech
introduce new struct NameVariant for Location names and variables, ge…
b2fb714 
…t rid of camelCase function from template
@sebastianczech
Change Go SDK path for security policy rule
b535826
@sebastianczech
extend configuration file with settings for copying static assets
ea21716
@sebastianczech
static files from pango in develop branch
d2424f3
@sebastianczech
add function to copy static assets
0824d64
@sebastianczech
change go sdk path for service and address group
54f99e3
@sebastianczech
Merge branch 'render-location' into copy-static-files
f10d323
@sebastianczech sebastianczech marked this pull request as ready for review March 6, 2024 14:13
@sebastianczech sebastianczech changed the title feat: Copy static files feat: Copy static files (assets) Mar 6, 2024
@pimielowski pimielowski self-requested a review March 7, 2024 20:45
pimielowski
pimielowski reviewed Mar 7, 2024
View reviewed changes
pkg/generate/asset.go Outdated Show resolved Hide resolved
assets/errors/panos.go Outdated Show resolved Hide resolved
cmd/mktp/config.yaml Outdated Show resolved Hide resolved
pkg/generate/asset.go Outdated Show resolved Hide resolved
pkg/generate/asset.go Outdated Show resolved Hide resolved
@shinmog
Copy link
Collaborator

shinmog commented Mar 8, 2024

I'm still actively updating and changing pango internals, much less any changes you guys would need. I'm not sure this should be merged to POC until we collectively get a little farther and the dust settles a bit.

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Mar 8, 2024 •
edited
Loading

I'm still actively updating and changing pango internals, much less any changes you guys would need. I'm not sure this should be merged to POC until we collectively get a little farther and the dust settles a bit.

I removed all files from pango

shinmog
shinmog approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then

pimielowski
pimielowski approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from render-location to main March 8, 2024 09:56
@sebastianczech sebastianczech merged commit ab72553 into main Mar 8, 2024
1 check passed
@sebastianczech sebastianczech deleted the copy-static-files branch March 8, 2024 09:59
This was referenced Mar 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinmog shinmog shinmog approved these changes

@pimielowski pimielowski pimielowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianczech @shinmog @pimielowski