Add imports location lock to serialize non-atomic operations #204
+70
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklimonda-cl
force-pushed
the
feat-import-locks
branch
from
75c37c1 to
8a42942
Compare
Adding and removing items from the imports location list is currently implemented in a non-atomic way, by first reading a list of items from the server, updating it locally, and sending a new list to the server. Introduce a (per-resource, per-location) lock to all resources that require modifications of the import list so that those operations are done sequentially.
kklimonda-cl
force-pushed
the
feat-import-locks
branch
from
8a42942 to
527da26
Compare
migara
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding and removing items from the imports location list is currently implemented in a non-atomic way, by first reading a list of items from the server, updating it locally, and sending a new list to the server.
Introduce a (per-resource, per-location) lock to all resources that require modifications of the import list so that those operations are done sequentially.
Closes: #203