Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add NAT policy specification #173

Merged
merged 6 commits into from
Oct 23, 2024
Merged

feat: Add NAT policy specification #173

merged 6 commits into from
Oct 23, 2024

Conversation

kklimonda-cl
Copy link
Contributor

@kklimonda-cl kklimonda-cl commented Oct 7, 2024 •
edited
Loading

Create manual NAT policy specification based on the API schema.
Additionally, update codegen to better map schema to terraform:

  • change terraform type of "nil" parameters from string to object: this affects this spec and ethernet (where one of variants is empty ha option). It's more in line with other variants this way.
  • Make "nil" variants optional.

Making "nil" variants optional lets us skip variant if "none" variant would be selected.

@kklimonda-cl kklimonda-cl force-pushed the feat-nat-spec branch 2 times, most recently from 7d82836 to 01afef4 Compare October 7, 2024 11:52
@kklimonda-cl kklimonda-cl force-pushed the feat-nat-spec branch 3 times, most recently from 0de46ca to 7537a99 Compare October 9, 2024 13:48
@kklimonda-cl kklimonda-cl requested a review from jaspalo October 10, 2024 14:52
@kklimonda-cl kklimonda-cl force-pushed the feat-nat-spec branch 2 times, most recently from a5fb7ce to dab5117 Compare October 11, 2024 08:30
jaspalo
jaspalo reviewed Oct 17, 2024
View reviewed changes
assets/pango/client.go Outdated Show resolved Hide resolved
assets/terraform/test/resource_address_group_test.go Show resolved Hide resolved
assets/terraform/test/panos_sweeper_test.go Show resolved Hide resolved
assets/terraform/test/resource_nat_policy_test.go Show resolved Hide resolved
assets/terraform/test/resource_nat_policy_test.go Outdated Show resolved Hide resolved
assets/terraform/test/resource_nat_policy_test.go Outdated Show resolved Hide resolved
assets/terraform/test/resource_nat_policy_test.go Outdated Show resolved Hide resolved
assets/terraform/test/resource_nat_policy_test.go Outdated Show resolved Hide resolved
assets/terraform/test/resource_nat_policy_test.go Outdated Show resolved Hide resolved
assets/terraform/test/resource_nat_policy_test.go Outdated Show resolved Hide resolved
@kklimonda-cl
Add NAT policy specification
84588c3
@kklimonda-cl
Drop "rulebase" variable from vsys location
79f8e2b 
Variable is not valid, and not being used to construct xpath any.
@kklimonda-cl
Rename some arguments in Terraform
6d1b873 
Introduce codegen overrides for terraform argument names, and update
CopyToPango() and CopyFromPang() code to properly handle name differences
between Terraform and Pango.
@kklimonda-cl
Add tests for panos_nat_policy
ee709c0
@kklimonda-cl
Fix acceptance tests that no longer compiled
3cfa125
@kklimonda-cl kklimonda-cl merged commit dc9e7af into main Oct 23, 2024
3 checks passed
@kklimonda-cl kklimonda-cl deleted the feat-nat-spec branch October 23, 2024 10:12
@kklimonda-cl kklimonda-cl linked an issue Oct 23, 2024 that may be closed by this pull request
Create YAML spec for NAT rules #176
Closed
@kklimonda-cl kklimonda-cl mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbil michalbil michalbil left review comments

@jaspalo jaspalo jaspalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create YAML spec for NAT rules
3 participants
@kklimonda-cl @michalbil @jaspalo