feat: Defer retrieval of system info and plugin data #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving both SystemInfo and Plugins during Initialize() call slows down client setup, which can lead to large slow down for some operations (e.g. terraform provider tests run twice as long due to that). This commit defers initialization of both to when data is accesssed by calling new SystemInfo() and Plugins() methods. The old behaviour can still be done when needed by explicitly calling RetrieveSystemInfo() and RetrievePlugins() after a call to Initialize().
kklimonda-cl
changed the title
michalbil
approved these changes
Sep 23, 2024
Co-authored-by: michalbil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving both SystemInfo and Plugins during Initialize() call slows down client setup, which can lead to large slow down for some operations (e.g. terraform provider tests run twice as long due to that).
This commit defers initialization of both to when data is accessed by calling new SystemInfo() and Plugins() methods. The old behavior can still be done when needed by explicitly calling RetrieveSystemInfo() and RetrievePlugins() after a call to Initialize().