Skip to content
This repository has been archived by the owner on Mar 16, 2023. It is now read-only.

Refactored recordedfuture.py added rfpoller class, fixed connection i… #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

recordedfuture-simonhornestedt
Copy link

@recordedfuture-simonhornestedt recordedfuture-simonhornestedt commented Jul 19, 2022

Description

  • Refactored the code and created RFPoller class, it is an adaption of the existing ft/csv.py that was used previously. But with functionality specific to the recorded future miners Much of the duplicated code that existed in IPRiskList, DomainRiskList and MasterRiskList have been moved to the RFPoller for more readable code.

  • Implemented the ignore_regex conf option to function properly on the response from the API

  • Removed the decode_gzip conf option since this is handled by requests

  • Fixed an issue of Connection Broken: IncompleteRead errors that occured when streaming the response to a DictReader by adding a cStringIO as a sort of buffer.

  • Fixed a faulty param sent ("output_format" -> "format") in the request to the API

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@recordedfuture-simonhornestedt recordedfuture-simonhornestedt marked this pull request as ready for review July 21, 2022 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant