fixed: panic on Normalizing nil claims

PaloAltoNetworks · Oct 7, 2019 · e5a134a · e5a134a
1 parent cbec154
commit e5a134a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/client/utils.go b/client/utils.go
@@ -150,6 +150,10 @@ func UnsecureClaimsFromToken(token string) ([]string, error) {
 // NormalizeAuth normalizes the response to a simple structure.
 func NormalizeAuth(c *types.MidgardClaims) (claims []string) {
 
+	if c == nil {
+		return
+	}
+
 	if c.Subject != "" {
 		claims = append(claims, "@auth:subject="+c.Subject)
 	}

diff --git a/client/utils_test.go b/client/utils_test.go
@@ -121,6 +121,15 @@ func TestUtils_NormalizeAuth(t *testing.T) {
 				So(v, ShouldContain, "@auth:d2=v2")
 			})
 		})
+
+		Convey("When I normalize nil claims", func() {
+
+			v := NormalizeAuth(nil)
+
+			Convey("Then the subject should be correct", func() {
+				So(len(v), ShouldEqual, 0)
+			})
+		})
 	})
 }