Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JWT library #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace JWT library #101

wants to merge 2 commits into from

Conversation

mheese
Copy link
Contributor

@mheese mheese commented Feb 15, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@mheese mheese requested review from primalmotion and t00f February 15, 2022 06:57
@t00f
Copy link
Contributor

t00f commented Feb 15, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "c890c7a0a911eea805968d7c912aad22490c677a",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "ce8a62c85c1857e90a82f86cf19bbbc3578b819c",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  }
]

@t00f
Copy link
Contributor

t00f commented Feb 16, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "80cc81bb3ca5083263a9be2a247acdc8effe63a9",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "ce8a62c85c1857e90a82f86cf19bbbc3578b819c",
    "pipeline": "master"
  }
]

@t00f
Copy link
Contributor

t00f commented Feb 16, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "9389559f5fbbd4e9e4e4024228245019b6795fb9",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "ce8a62c85c1857e90a82f86cf19bbbc3578b819c",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  }
]

@t00f
Copy link
Contributor

t00f commented Feb 17, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "d8b02a6bde409fabea8ddc3055abece437544366",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "ce8a62c85c1857e90a82f86cf19bbbc3578b819c",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  }
]

@t00f
Copy link
Contributor

t00f commented Feb 17, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "2e132851e434d73af3d190e1811ce51b6a7d86b2",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "ce8a62c85c1857e90a82f86cf19bbbc3578b819c",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  }
]

@t00f
Copy link
Contributor

t00f commented Feb 18, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "2e132851e434d73af3d190e1811ce51b6a7d86b2",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "ce8a62c85c1857e90a82f86cf19bbbc3578b819c",
    "pipeline": "master"
  }
]

@t00f
Copy link
Contributor

t00f commented Feb 22, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "ba3de740073bab8240757c39a58b2355613ae753",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "f4562d3a46af78dd5515919c2ccae9aaf60f000d",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  }
]

primalmotion
primalmotion reviewed Feb 23, 2022
View reviewed changes
tokenutils/tokenutils.go
@@ -49,7 +49,8 @@ func UnsecureClaimsMap(token string) (claims map[string]interface{}, err error)
return nil, errors.New("invalid jwt: not enough segments")
}

data, err := jwt.DecodeSegment(parts[1])
// NOTE: DecodeSegment() is deprecated and will go away in a future library release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is replaced by what? maybe we should update it right away

@t00f
Copy link
Contributor

t00f commented Feb 24, 2022

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "replace-insecure-jwt",
    "component": "backend",
    "pr-id": "1542",
    "commit-sha": "7159d895ca139924bbaefc43e5a63bbca244088d",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "gaia",
    "pr-id": "764",
    "commit-sha": "be9345de06c08541d8cd936f187dc9b0f9d9f537",
    "pipeline": "master"
  },
  {
    "project": "replace-insecure-jwt",
    "component": "addedeffect",
    "pr-id": "101",
    "commit-sha": "cfe94ad9611f52f771a99a5a616f69bca2854685",
    "pipeline": "master"
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primalmotion primalmotion primalmotion left review comments

@t00f t00f Awaiting requested review from t00f

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mheese @t00f @primalmotion