Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added #2683

Closed
wants to merge 3 commits into from
Closed

added #2683

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d630e2a
added
Mayankpulse333 Dec 28, 2024
6ec2164
adding const in it
Mayankpulse333 Dec 28, 2024
9477b72
fixing linting issue
Mayankpulse333 Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 120 additions & 0 deletions test/views/after_auth_screens/profile/edit_profile_page_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
import 'package:flutter/material.dart';
import 'package:flutter_localizations/flutter_localizations.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mockito/mockito.dart';
import 'package:talawa/utils/app_localization.dart';
import 'package:talawa/view_model/after_auth_view_models/profile_view_models/edit_profile_view_model.dart';
import 'package:talawa/views/after_auth_screens/profile/edit_profile_page.dart';
import 'package:talawa/views/base_view.dart';

import '../../../helpers/test_helpers.dart';
import '../../../helpers/test_locator.dart';

Widget createEditProfilePage({required EditProfilePageViewModel viewModel}) {
return BaseView<EditProfilePageViewModel>(
onModelReady: (model) => model.initialize(),
builder: (context, model, child) {
return MaterialApp(
locale: const Locale('en'),
localizationsDelegates: [
const AppLocalizationsDelegate(isTest: true),
GlobalMaterialLocalizations.delegate,
GlobalWidgetsLocalizations.delegate,
],
home: Scaffold(
key: const Key('EditProfileScreenScaffold'),
body: EditProfilePage(),
),
);
},
);
}

void main() {
setUpAll(() {
TestWidgetsFlutterBinding.ensureInitialized();
testSetupLocator();
registerServices();
});

Comment on lines +33 to +39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add tearDown to ensure proper test isolation.

The setup is good but missing cleanup. Add tearDown to prevent test interference.

 void main() {
   setUpAll(() {
     TestWidgetsFlutterBinding.ensureInitialized();
     testSetupLocator();
     registerServices();
   });
+
+  tearDownAll(() {
+    locator.reset();
+  });
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void main() {
setUpAll(() {
TestWidgetsFlutterBinding.ensureInitialized();
testSetupLocator();
registerServices();
});
void main() {
setUpAll(() {
TestWidgetsFlutterBinding.ensureInitialized();
testSetupLocator();
registerServices();
});
tearDownAll(() {
locator.reset();
});

group('EditProfilePage Tests', () {
testWidgets('Check if profile image and button are displayed',
(tester) async {
await tester.pumpWidget(
createEditProfilePage(
viewModel: locator<EditProfilePageViewModel>(),
),
);
await tester.pumpAndSettle();

expect(find.byKey(const Key('profilepic')), findsOneWidget);
expect(find.byKey(const Key('AddRemoveImageButton')), findsOneWidget);
});

testWidgets('Test Add/Remove Image Button functionality', (tester) async {
await tester.pumpWidget(
createEditProfilePage(
viewModel: locator<EditProfilePageViewModel>(),
),
);
await tester.pumpAndSettle();

final addRemoveButton = find.byKey(const Key('AddRemoveImageButton'));
await tester.tap(addRemoveButton);
await tester.pumpAndSettle();

expect(find.byType(BottomSheet), findsOneWidget);
final cameraButton = find.byKey(const Key('selectCamera'));
final galleryButton = find.byKey(const Key('selectGallery'));
expect(cameraButton, findsOneWidget);
expect(galleryButton, findsOneWidget);

await tester.tap(cameraButton);
await tester.pumpAndSettle();
});

testWidgets('Check if first and last name text fields are present',
(tester) async {
await tester.pumpWidget(
createEditProfilePage(
viewModel: locator<EditProfilePageViewModel>(),
),
);
await tester.pumpAndSettle();

expect(find.byKey(const Key('FirstNameTextField')), findsOneWidget);
expect(find.byType(TextFormField), findsWidgets);
});

testWidgets('Test Update button functionality', (tester) async {
await tester.pumpWidget(
createEditProfilePage(
viewModel: locator<EditProfilePageViewModel>(),
),
);
await tester.pumpAndSettle();

final updateButton = find.byKey(const Key('updatebtn'));
expect(updateButton, findsOneWidget);

await tester.tap(updateButton);
await tester.pump();
verify(locator<EditProfilePageViewModel>().updateUserProfile(
firstName: anyNamed('firstName'),
lastName: anyNamed('lastName'),
newImage: anyNamed('newImage')));
});

testWidgets('Check if Email section is displayed', (tester) async {
await tester.pumpWidget(
createEditProfilePage(
viewModel: locator<EditProfilePageViewModel>(),
),
);
await tester.pumpAndSettle();

expect(find.textContaining('Email'), findsOneWidget);
expect(find.byIcon(Icons.email), findsOneWidget);
});
});
}
MayankJha014 marked this conversation as resolved.
Show resolved Hide resolved
Loading