-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Venue Management for Event Plugin (GSoC) #2526
Conversation
[Fix] User can delete any event (Front-end)
- Widgets common between add_event_dialog.dart and edit_event_dialog.dart have been separated into file event_widgets.dart - Data is passed as parameter - Register form also reformatted
Fix: #654 Sort the Organization Names in Join_Organization Page
- Reformatted with flutter format - URL Page Animation extracted and moved to other file
[Refactoring] Dart file size reduction
* lang addition * lng-add * static string removal * language changes * chgs in main * test update
* ui added * adding lng widget * bug fix * test upd
* chore: fixes linting issue * ptch: replaces event list with displayed events list
* Replacing extra widgets for toasts with Custom Toast and making it uniform * removed snackbar.dart due to no implementation * flutter format * merge conflict resolved
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Add files via upload * Update pull-request.yml
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main --------- Co-authored-by: Peter Harrison <[email protected]>
Warning Review failedThe pull request is closed. WalkthroughThe recent changes introduce a venue management system to the event plugin, allowing users to manage venue details, such as ID, capacity, description, image URL, name, and organization ID. This includes the addition of a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CreateEventPage
participant CreateEventViewModel
participant GraphQLServer
User ->> CreateEventPage: Select "Venue" option
CreateEventPage ->> CreateEventViewModel: fetchVenues()
CreateEventViewModel ->> GraphQLServer: venueListQuery()
GraphQLServer -->> CreateEventViewModel: List of venues
CreateEventViewModel -->> CreateEventPage: List of venues
CreateEventPage ->> VenueBottomSheet: Display venues
User ->> VenueBottomSheet: Search and Select venue
VenueBottomSheet -->> CreateEventPage: Selected venue
CreateEventPage -->> User: Display selected venue
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
What kind of change does this PR introduce?
This PR introduces a new feature for venue management within the event management application. It adds basic CRUD capabilities to manage venue information, including name, capacity, description, and image URL.
Issue Number:
Fixes #2522
Did you add tests for your changes?
Yes
Snapshots/Videos:
Screenrecorder-2024-07-10-19-12-20-821.1.mp4
If relevant, did you update the documentation?
Yes
Does this PR introduce a breaking change?
Yes
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
VenueBottomSheet
widget for selecting venues from a list.VenueCard
widget to display venue details with selection highlighting.Enhancements