-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Written test for profile_page_view_model #2430
Written test for profile_page_view_model #2430
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2430 +/- ##
===========================================
+ Coverage 95.74% 95.88% +0.14%
===========================================
Files 152 152
Lines 7518 7518
===========================================
+ Hits 7198 7209 +11
+ Misses 320 309 -11 ☔ View full report in Codecov by Sentry. |
@Cioppolo14 please assign reviewers. |
@DMills27 @noman2002 Can you review this PR? |
This is an update on the PR merging freeze:
We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise. Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST). If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new |
What kind of change does this PR introduce?
This PR makes profile_page_view_model 100% code covered.
Issue Number:
Fixes #2142
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Raised code coverage to 100% of the profile page view model.
Does this PR introduce a breaking change?
no
Other information
Have you read the contributing guide?
yes