bfix: handles error incase of unsuccessful logout #2420

am-casper · 2024-03-11T14:33:57Z

What kind of change does this PR introduce?
This fixes a bug. Error handing in case of unsuccessful logging out is improved.

Issue Number: #2416

Fixes #2416

Did you add tests for your changes?

Updated a couple of tests.

Summary

As a user, i don't want to not able to log out properly and stuck between the App Settings and Select Language screen, everytime a logout is unsuccessful.

Does this PR introduce a breaking change?

This fixes a critical bug, especially for users who have unstable internet connection.

Have you read the contributing guide?

Yes

github-actions · 2024-03-11T14:34:23Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

github-actions

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

codecov · 2024-03-11T19:26:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (8652d99) to head (26aba3c).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2420   +/-   ##
========================================
  Coverage    95.74%   95.74%           
========================================
  Files          152      152           
  Lines         7518     7518           
========================================
  Hits          7198     7198           
  Misses         320      320

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dhanagopu · 2024-03-13T04:48:17Z

@CyberWake @Kevoniat Can you review this PR?

noman2002 · 2024-03-14T18:32:24Z

@am-casper Please attach a video.

am-casper · 2024-03-15T11:06:15Z

@noman2002 This is after the bug fix. Before the bug was fixed, app crashes after logout if internet connectivity is weak
https://github.com/PalisadoesFoundation/talawa/assets/103204377/ba41e69b-c28b-4e2a-a79a-5f6258877c61

noman2002

When logged out, navigate it to the login screen not on the language selection screen.

am-casper · 2024-03-18T14:59:09Z

When logged out, navigate it to the login screen not on the language selection screen.

@noman2002 updated the commit. Kindly have a look

literalEval · 2024-03-20T06:20:23Z

lib/views/after_auth_screens/app_settings/app_settings_page.dart

+                            final bool isLogoutSuccessful =
+                                await model.logout();
+                            if (!isLogoutSuccessful) {
+                              throw Error(); //checks whether the logout was successful or not.


Where is this error catched ?

@literalEval there's a catch block at line 316. please have a look at it.

literalEval · 2024-03-20T06:22:15Z

lib/view_model/after_auth_view_models/settings_view_models/app_setting_view_model.dart

@@ -14,10 +14,11 @@ class AppSettingViewModel extends BaseModel {
  ///   None
  ///
  /// **returns**:
-  ///   None
-  Future<void> logout() async {
+  /// * `Future<bool>`: A [Future] that resolves to a [bool] value indicating whether the user has been logged out.


Write a small non-redundant sentence.
Like: "Logs the user out and returns logout status"

@literalEval updated.

palisadoes · 2024-03-22T17:56:59Z

This is an update on the PR merging freeze:

In the next few hours we will be merging the develop-userTypeFix branch into the develop branch.
The develop-userTypeFix branch was created to fix a long standing design flaw where Admins were Admins of all organizations, not specific ones.
The userType field has been removed from the User collection and it has been replaced by an appUserProfileId field.
1. This field is null if the user isn’t registered to use the apps. This will help people to add users manually during the event checkin process, or if an Admin wants to manually add someone in the Admin dashboard.
2. When not null the AppUserProfileID will reference a AppUserProfile collection with App related information such as the organizations for which a user may be an Admin.
3. The updated schema can be found here https://github.com/PalisadoesFoundation/talawa-api/blob/develop-userTypeFix/schema.graphql
4. This is the parent issue that we have been using to track progress:
  1. PARENT ISSUE: Fix the usage of userType talawa-api#1965
This merge will cause some conflicts in your PR.

We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise.

Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST).

If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new AppUserProfileID methodology.

noman2002

Looks fine to me.

github-actions bot reviewed Mar 11, 2024

View reviewed changes

am-casper force-pushed the logout-issue branch from e21972d to 60fee87 Compare March 11, 2024 17:31

am-casper force-pushed the logout-issue branch 4 times, most recently from cf3997d to 18b869f Compare March 12, 2024 16:19

dhanagopu requested review from Kevoniat and CyberWake March 13, 2024 04:47

dhanagopu added the Ready 4 PR Review label Mar 13, 2024

noman2002 requested changes Mar 17, 2024

View reviewed changes

am-casper force-pushed the logout-issue branch 3 times, most recently from 7e73d75 to 7c49ced Compare March 18, 2024 14:22

am-casper added 3 commits March 18, 2024 22:11

bfix: handles error incase of unsuccessful logout

70caeac

test: adds Test if Logout is successful test

610f6f6

ptch: routes to login page after logout

bfa7ba6

am-casper force-pushed the logout-issue branch from 7c49ced to bfa7ba6 Compare March 18, 2024 16:41

literalEval requested changes Mar 20, 2024

View reviewed changes

docs: changed a sentence to a better non reductant one

26aba3c

noman2002 requested a review from literalEval March 23, 2024 15:17

noman2002 approved these changes Mar 23, 2024

View reviewed changes

palisadoes merged commit 3151796 into PalisadoesFoundation:develop Mar 23, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bfix: handles error incase of unsuccessful logout #2420

bfix: handles error incase of unsuccessful logout #2420

am-casper commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

github-actions bot left a comment

codecov bot commented Mar 11, 2024 •

edited

Loading

dhanagopu commented Mar 13, 2024

noman2002 commented Mar 14, 2024

am-casper commented Mar 15, 2024 •

edited

Loading

noman2002 left a comment

am-casper commented Mar 18, 2024

literalEval Mar 20, 2024

am-casper Mar 20, 2024

literalEval Mar 20, 2024

am-casper Mar 20, 2024

palisadoes commented Mar 22, 2024

noman2002 left a comment

bfix: handles error incase of unsuccessful logout #2420

bfix: handles error incase of unsuccessful logout #2420

Conversation

am-casper commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 11, 2024 • edited Loading

Codecov Report

dhanagopu commented Mar 13, 2024

noman2002 commented Mar 14, 2024

am-casper commented Mar 15, 2024 • edited Loading

noman2002 left a comment

Choose a reason for hiding this comment

am-casper commented Mar 18, 2024

literalEval Mar 20, 2024

Choose a reason for hiding this comment

am-casper Mar 20, 2024

Choose a reason for hiding this comment

literalEval Mar 20, 2024

Choose a reason for hiding this comment

am-casper Mar 20, 2024

Choose a reason for hiding this comment

palisadoes commented Mar 22, 2024

noman2002 left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 11, 2024 •

edited

Loading

am-casper commented Mar 15, 2024 •

edited

Loading