Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Join organisation button has stick to the bottom #2411

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

SumitPareek2401
Copy link
Contributor

What kind of change does this PR introduce?
Bugfix

Issue Number:
Fixes #2392

Fixes #

Did you add tests for your changes?
Yes

Snapshots/Videos:

If relevant, did you update the documentation?

Summary
This pull request solves the bug report of sticking the "join organization button" to the bottom.

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?
Yes

Copy link

github-actions bot commented Mar 6, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (93c4f12) to head (05fee84).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2411   +/-   ##
========================================
  Coverage    95.83%   95.83%           
========================================
  Files          152      152           
  Lines         7396     7403    +7     
========================================
+ Hits          7088     7095    +7     
  Misses         308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link
Contributor

@noman2002 @DMills27 Can you review this PR?

@Ayush0Chaudhary
Copy link
Contributor

Add screen shot

@SumitPareek2401
Copy link
Contributor Author

drawer1

@Olatade
Copy link

Olatade commented Mar 12, 2024

@SumitPareek2401 Please update your branch with the latest changes.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palisadoes palisadoes merged commit a6fa1c4 into PalisadoesFoundation:develop Mar 12, 2024
8 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: The "Join Organisation button" should stick to the bottom.
6 participants