Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navigation: On clicking change language it navigates to home screen. #2402

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix Navigation: On clicking change language it navigates to home screen. #2402

merged 2 commits into from
Feb 28, 2024

Conversation

soaham-pimparkar
Copy link
Contributor

@soaham-pimparkar soaham-pimparkar commented Feb 26, 2024

What kind of change does this PR introduce?

-> Fixed the navigation, where app used to navigate back to the home page instead of the Select Language page on clicking the Select Language button.

Issue Number:

-> fixes #2394

Did you add tests for your changes?

-> No

Does this PR introduce a breaking change?

-> No

Have you read the contributing guide?

-> Yes

Snapshots/Videos:

video_2024-02-27_03-05-24.mp4

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@Cioppolo14
Copy link
Contributor

@soaham-pimparkar Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details.

Also, please fix the failing test.

@palisadoes palisadoes merged commit 4c1e931 into PalisadoesFoundation:develop Feb 28, 2024
7 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Feb 28, 2024
…en. (PalisadoesFoundation#2402)

* fixed select language button

* updated select language bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Navigation: On clicking change language it navigates to home screen.
4 participants