Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the geolocator package #2388

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Remove the geolocator package #2388

merged 1 commit into from
Feb 23, 2024

Conversation

YoussefMoRabie
Copy link
Contributor

What kind of change does this PR introduce?

Remove the geolocator package

Issue Number:

Fixes #2384

Did you add tests for your changes?

No

Have you read the contributing guide?

Yes

@github-actions GitHub Actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@palisadoes palisadoes merged commit aafddab into PalisadoesFoundation:develop Feb 23, 2024
8 of 9 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Feb 28, 2024
@YoussefMoRabie
Remove the geolocator package (PalisadoesFoundation#2388)
ef29d9f
palisadoes added a commit that referenced this pull request Mar 1, 2024
@Dante291 @dependabot
@palisadoes @YoussefMoRabie @Insiyaya
Fix userType (Fixed SignUp and LogIn) (#2389)
7d068f5 
* Bump syncfusion_flutter_calendar from 24.2.3 to 24.2.4 (#2382)

Bumps [syncfusion_flutter_calendar](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.2.3 to 24.2.4.
- [Release notes](https://github.com/syncfusion/flutter-widgets/releases)
- [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages)

---
updated-dependencies:
- dependency-name: syncfusion_flutter_calendar
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump url_launcher_platform_interface from 2.3.1 to 2.3.2 (#2381)

Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.2/packages/url_launcher)

---
updated-dependencies:
- dependency-name: url_launcher_platform_interface
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump geolocator from 10.1.0 to 11.0.0 (#2378)

Bumps [geolocator](https://github.com/baseflow/flutter-geolocator) from 10.1.0 to 11.0.0.
- [Commits](Baseflow/flutter-geolocator@geolocator_v10.1.0...geolocator_v11.0.0)

---
updated-dependencies:
- dependency-name: geolocator
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump permission_handler from 11.2.1 to 11.3.0 (#2379)

Bumps [permission_handler](https://github.com/baseflow/flutter-permission-handler) from 11.2.1 to 11.3.0.
- [Commits](Baseflow/flutter-permission-handler@permission_handler_v11.2.1...permission_handler_v11.3.0)

---
updated-dependencies:
- dependency-name: permission_handler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Upgraded github actions to the latest versions (#2385)

Co-authored-by: Peter Harrison <[email protected]>

* Remove the geolocator package (#2388)

* added additional test cases to edit profile page test file (#2331)

* added additional test cases to edit profile page test file

* updates the code

* fixed failing tests

* fixed

* Done some corrections in previous code

* Update edit_profile_page_test.dart

* Update edit_profile_page_test.dart

* Made some changes to run the tests

Made some changes to run the tests

* Fix UserType

* Fixing linting errors

* Fixing linting errors

* Fixing minor errors

* Fixing failing tests

* Fixing failing tests

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Yousef Rabia <[email protected]>
Co-authored-by: Insiya <[email protected]>
palisadoes added a commit that referenced this pull request Mar 23, 2024
@varshith257 @Dante291
@dependabot @palisadoes @YoussefMoRabie @Insiyaya
Fix userType (Fixed SignUp and LogIn) (#2389) (#2435)
0cd07d5 
* Bump syncfusion_flutter_calendar from 24.2.3 to 24.2.4 (#2382)

Bumps [syncfusion_flutter_calendar](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.2.3 to 24.2.4.
- [Release notes](https://github.com/syncfusion/flutter-widgets/releases)
- [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages)

---
updated-dependencies:
- dependency-name: syncfusion_flutter_calendar
  dependency-type: direct:production
  update-type: version-update:semver-patch
...




* Bump url_launcher_platform_interface from 2.3.1 to 2.3.2 (#2381)

Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.2/packages/url_launcher)

---
updated-dependencies:
- dependency-name: url_launcher_platform_interface
  dependency-type: direct:production
  update-type: version-update:semver-patch
...




* Bump geolocator from 10.1.0 to 11.0.0 (#2378)

Bumps [geolocator](https://github.com/baseflow/flutter-geolocator) from 10.1.0 to 11.0.0.
- [Commits](Baseflow/flutter-geolocator@geolocator_v10.1.0...geolocator_v11.0.0)

---
updated-dependencies:
- dependency-name: geolocator
  dependency-type: direct:production
  update-type: version-update:semver-major
...




* Bump permission_handler from 11.2.1 to 11.3.0 (#2379)

Bumps [permission_handler](https://github.com/baseflow/flutter-permission-handler) from 11.2.1 to 11.3.0.
- [Commits](Baseflow/flutter-permission-handler@permission_handler_v11.2.1...permission_handler_v11.3.0)

---
updated-dependencies:
- dependency-name: permission_handler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...




* Upgraded github actions to the latest versions (#2385)



* Remove the geolocator package (#2388)

* added additional test cases to edit profile page test file (#2331)

* added additional test cases to edit profile page test file

* updates the code

* fixed failing tests

* fixed

* Done some corrections in previous code

* Update edit_profile_page_test.dart

* Update edit_profile_page_test.dart

* Made some changes to run the tests

Made some changes to run the tests

* Fix UserType

* Fixing linting errors

* Fixing linting errors

* Fixing minor errors

* Fixing failing tests

* Fixing failing tests

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Parag Gupta <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Yousef Rabia <[email protected]>
Co-authored-by: Insiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noman2002 noman2002 noman2002 approved these changes

@palisadoes palisadoes palisadoes approved these changes

@literalEval literalEval Awaiting requested review from literalEval

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the geolocator package
3 participants
@YoussefMoRabie @palisadoes @noman2002