-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edited splash_screen_test #2376
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
@Sandesh-03 Please fix the failing tests. |
@Sandesh-03 Are you working on this? |
@Cioppolo14 yes |
@Sandesh-03 Please tell me when this PR will be ready. |
@Sandesh-03 are you facing any issue, need any help? |
Yeh. The test is running fine on my pc I have also tried the command which failed during review, can you help me with this? |
The reason for failing tests is, your code is not properly formatted. use this procedure before raising any PR to talawa:
|
@Azad99-9 |
What kind of change does this PR introduce?
Unit Test
Issue Number:
Fixes #2145
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
I have solved the issues that were mentioned.
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes