added check for all translation file #2275
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
There was a problem hiding this comment.
For the python script:
- Follow the Google Python style guide especially in the DocString area. https://google.github.io/styleguide/pyguide.html
- Make sure that the script is python
black,pydocstring,pylint,flake8andpycodestylecompliant - Use the
countline.pyscript in theworkflowdirectory as a guide
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2275 +/- ##
========================================
Coverage 90.12% 90.12%
========================================
Files 156 156
Lines 7435 7435
========================================
Hits 6701 6701
Misses 734 734 ☔ View full report in Codecov by Sentry. |
|
Yes I have tested them and made the code complaint to these script using cli |
.github/workflows/pull-request.yml
Outdated
| @@ -118,13 +123,15 @@ jobs: | |||
| with: | |||
| verbose: true | |||
| fail_ci_if_error: false | |||
| name: '${{env.CODECOV_UNIQUE_NAME}}' | |||
| name: "${{env.CODECOV_UNIQUE_NAME}}" | |||
There was a problem hiding this comment.
Revert all these cases. We use single quotes in our YAML files
.github/workflows/pull-request.yml
Outdated
| # git branch | ||
| # pip install GitPython | ||
| # python ./.github/workflows/documentationcheck.py --repository ${{github.repository}} --merge_branch_name ${{github.ref_name}} | ||
| # - name: Echo the GitHub environment for troubleshooting |
There was a problem hiding this comment.
Why were these spaces included? Only edit the second that relate to the issue.
There was a problem hiding this comment.
I have removed these spaces,actually when I integrated the python script in the workflow file then auto save has formatted the file that's why there are some changes like space double quotes.
There was a problem hiding this comment.
Please review the changes
palisadoes
merged commit 1172c51
into
PalisadoesFoundation:develop
* added check for all translation file * fix falling test * fix the python style guide * made the requested changes * now the script will report for every file if there is error * revert back the double quotes to single quotes * error message will show path of file * improved the output message * used namedtuple to improve readability
* added check for all translation file * fix falling test * fix the python style guide * made the requested changes * now the script will report for every file if there is error * revert back the double quotes to single quotes * error message will show path of file * improved the output message * used namedtuple to improve readability
What kind of change does this PR introduce?
During PR process it checks all the translations files
Issue Number:
Fixes #2242
Did you add tests for your changes?
NO
Have you read the contributing guide?
Yes