Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing UX by introducing User Profile Modification Feature #2268

Merged
merged 24 commits into from
Dec 27, 2023
Merged

Enhancing UX by introducing User Profile Modification Feature #2268

merged 24 commits into from
Dec 27, 2023

Conversation

Dante291
Copy link
Contributor

@Dante291 Dante291 commented Dec 24, 2023 •
edited
Loading

What kind of change does this PR introduce?

Introducing user profile modification feature where user would be able to customize their profile.

Issue Number:

Fixes #2261

Video

edit.profile.1.mp4

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

Yes

Have you read the contributing guide?

Yes

@github-actions GitHub Actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c902baa) 88.27% compared to head (a459cb5) 90.08%.
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2268      +/-   ##
===========================================
+ Coverage    88.27%   90.08%   +1.80%     
===========================================
  Files          155      155              
  Lines         7352     7430      +78     
===========================================
+ Hits          6490     6693     +203     
+ Misses         862      737     -125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dante291 Dante291 changed the title Feature request: Enhancing UX by introducing User Profile Modification Feature Enhancing UX by introducing User Profile Modification Feature Dec 24, 2023
@Dante291
Copy link
Contributor Author

Made profile pic visible at other screens of the app too:

Screenshot_1703412506

Screenshot_1703412514

@Dante291
Copy link
Contributor Author

@noman2002 @Cioppolo14 @Kevoniat Please assign reviewers for this, thanks.

@Dante291 Dante291 mentioned this pull request Dec 24, 2023
Merged
@palisadoes palisadoes requested review from noman2002, literalEval, Ayush0Chaudhary and Kevoniat and removed request for aashimawadhwa December 25, 2023 13:43
literalEval
literalEval requested changes Dec 25, 2023
View reviewed changes
Copy link
Member

@literalEval literalEval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove print statements.
  2. Write good documentation. Don't leave the template as is.
  3. Add empty lines to make the code more readable.

lib/view_model/after_auth_view_models/add_post_view_models/add_post_view_model.dart Outdated Show resolved Hide resolved
lib/view_model/after_auth_view_models/add_post_view_models/add_post_view_model.dart Outdated Show resolved Hide resolved
lib/view_model/after_auth_view_models/profile_view_models/edit_profile_view_model.dart Outdated Show resolved Hide resolved
lib/view_model/after_auth_view_models/profile_view_models/edit_profile_view_model.dart Outdated Show resolved Hide resolved
lib/views/after_auth_screens/add_post_page.dart Outdated Show resolved Hide resolved
lib/view_model/after_auth_view_models/profile_view_models/edit_profile_view_model.dart Outdated Show resolved Hide resolved
lib/view_model/after_auth_view_models/profile_view_models/edit_profile_view_model.dart Outdated Show resolved Hide resolved
lib/view_model/after_auth_view_models/profile_view_models/edit_profile_view_model.dart Show resolved Hide resolved
@Dante291 Dante291 requested a review from literalEval December 25, 2023 19:40
@literalEval
Copy link
Member

@Dante291 fix the failing checks. Refactor the code wherever necessary.

@Dante291
Copy link
Contributor Author

@literalEval please review sir.

@Dante291 Dante291 requested a review from literalEval December 26, 2023 14:08
@literalEval
Copy link
Member

@Dante291 use SizeConfig everywhere. Similarly, add trailing commas wherever needed and refactor.

@Dante291 Dante291 requested a review from literalEval December 26, 2023 14:53
@Dante291
Copy link
Contributor Author

@literalEval properly formatted and used dynamic sizing wherever possible, please review sir.

literalEval
literalEval requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@literalEval literalEval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cover the uncovered lines in tests. Use codecov to find out the missing lines.

@Dante291
Copy link
Contributor Author

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c902baa) 88.27% compared to head (a459cb5) 90.08%.
Report is 4 commits behind head on develop.

Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@literalEval All lines covered sir

@Dante291 Dante291 requested a review from literalEval December 27, 2023 02:40
literalEval
literalEval approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@literalEval literalEval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palisadoes palisadoes merged commit a7059f3 into PalisadoesFoundation:develop Dec 27, 2023
7 checks passed
Abhisheksainii pushed a commit to Abhisheksainii/talawa that referenced this pull request Jan 3, 2024
@Dante291 @Abhisheksainii
Enhancing UX by introducing User Profile Modification Feature (Palisa…
ece173d 
…doesFoundation#2268)

* Feature request: Implement User Profile Modification Feature

* changes

* changes

* proper dynamic call

* fixing tests

* fixing coverage

* writing test for missing lines

* writing test for missing lines

* writing test for missing lines

* writing test for missing lines

* writing test for missing lines

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* test for missing lines

* adding requested changes

* adding requested changes

* test for missing lines
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
@Dante291 @palisadian
Enhancing UX by introducing User Profile Modification Feature (Palisa…
97038ef 
…doesFoundation#2268)

* Feature request: Implement User Profile Modification Feature

* changes

* changes

* proper dynamic call

* fixing tests

* fixing coverage

* writing test for missing lines

* writing test for missing lines

* writing test for missing lines

* writing test for missing lines

* writing test for missing lines

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* adding requested changes

* test for missing lines

* adding requested changes

* adding requested changes

* test for missing lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literalEval literalEval literalEval approved these changes

@palisadoes palisadoes palisadoes approved these changes

@noman2002 noman2002 Awaiting requested review from noman2002 noman2002 is a code owner

@Ayush0Chaudhary Ayush0Chaudhary Awaiting requested review from Ayush0Chaudhary

@Kevoniat Kevoniat Awaiting requested review from Kevoniat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User should be able to edit profile
3 participants
@Dante291 @literalEval @palisadoes