Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for join_organisation_after_auth.dart #2260

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Test for join_organisation_after_auth.dart #2260

merged 3 commits into from
Dec 19, 2023

Conversation

Dante291
Copy link
Contributor

What kind of change does this PR introduce?

test for join org.

Issue Number:

Fixes #2152

Did you add tests for your changes?

yes

Have you read the contributing guide?

yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06fdb92) 87.38% compared to head (c15da25) 87.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2260      +/-   ##
===========================================
+ Coverage    87.38%   87.65%   +0.27%     
===========================================
  Files          155      155              
  Lines         7356     7356              
===========================================
+ Hits          6428     6448      +20     
+ Misses         928      908      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@palisadoes palisadoes merged commit 7d74da9 into PalisadoesFoundation:develop Dec 19, 2023
7 checks passed
Abhisheksainii pushed a commit to Abhisheksainii/talawa that referenced this pull request Jan 3, 2024
* Test for join_organisation_after_auth.dart

* modify

* adding more tests for complete coverage
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
* Test for join_organisation_after_auth.dart

* modify

* adding more tests for complete coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for join_organisation_after_auth.dart
3 participants