fix: Removed all references to Google firebase #2257

Abhisheksainii · 2023-12-18T11:21:16Z

What kind of change does this PR introduce?

BugFix

Issue Number:

Did you add tests for your changes?
No.
P.S: Tests were already there, just commented those references which were discontinued.

Snapshots/Videos:

If relevant, did you update the documentation?

No

Summary

The firebase notification services were discontinued as they were a dependency. They were causing errors while creating Events due to exception that was being thrown from backend ("Notification service not found"). The changes that I have made mostly includes commenting out and deleting the code.
Issue: #2195

Does this PR introduce a breaking change?

Removed Firebase Notifications and its references, the impact has been taken care of in this issue (PalisadoesFoundation/talawa-api#1500)

Other information
Merge this PR after this (PalisadoesFoundation/talawa-api#1503) has been merged by backend, otherwise it will cause issue while creating events.

Have you read the contributing guide?

Yes

github-actions · 2023-12-18T11:21:42Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

github-actions

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Abhisheksainii · 2023-12-18T16:23:16Z

@palisadoes @noman2002 can someone please approve the workflows

palisadoes · 2023-12-18T19:21:58Z

@Abhisheksainii

Have you tested this with the latest upstream of the API?
We just merged a PR that removed firebase.

Abhisheksainii · 2023-12-19T04:38:22Z

@Abhisheksainii

Have you tested this with the latest upstream of the API?

We just merged a PR that removed firebase.

I haven't but will test it.

lib/view_model/after_auth_view_models/profile_view_models/profile_page_view_model.dart

lib/firebase_options.dart

android/app/src/main/AndroidManifest.xml

lib/services/database_mutation_functions.dart

Abhisheksainii · 2023-12-19T17:30:07Z

Don't merge this PR, some tests are left

Cioppolo14 · 2023-12-27T19:57:02Z

@Abhisheksainii Are you still working on this?

Abhisheksainii · 2023-12-27T20:00:30Z

Yes

Abhisheksainii · 2023-12-27T20:01:17Z

Yes, testing phase is going on.
The issue is from backend side due to which I am unable to test.

Abhisheksainii · 2024-01-02T11:27:31Z

@Kevoniat @Cioppolo14 you can merge the PR, testing has been done

test/utils_tests/queries_test.dart

Abhisheksainii · 2024-01-02T18:34:07Z

@literalEval I have done the changes

codecov · 2024-01-03T12:15:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ac0633) 92.48% compared to head (f194e95) 93.64%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2257      +/-   ##
===========================================
+ Coverage    92.48%   93.64%   +1.16%     
===========================================
  Files          158      157       -1     
  Lines         7633     7533     -100     
===========================================
- Hits          7059     7054       -5     
+ Misses         574      479      -95

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Abhisheksainii · 2024-01-03T12:35:00Z

@literalEval all the required changes has been done and issue has been also created

Abhisheksainii · 2024-01-04T07:01:52Z

@palisadoes @literalEval @Kevoniat kindly merge the PR as all the required changes has been done

palisadoes · 2024-01-04T20:04:56Z

Please work with @literalEval @Kevoniat for approvals. I will not be checking back in.

Abhisheksainii · 2024-01-06T09:25:10Z

@Kevoniat @literalEval can you please approve the workflows?

Azad99-9 · 2024-01-06T19:40:15Z

@Abhisheksainii please write tests to the missing lines.

Abhisheksainii · 2024-01-06T20:06:20Z

@Abhisheksainii please write tests to the missing lines.
@Azad99-9
I think the files that I have changed doesn't require tests to be written and as for the the issue in profile_page_view_model.dart file. It was assigned to Parag and it has been merged.

palisadoes · 2024-01-07T10:06:42Z

@Kevoniat @DMills27 @Ayush0Chaudhary @literalEval please take a look. We really need this code removed so we can proceed with our roadmap

literalEval

LGTM

…2257) * feature: Removed all references to Google firebase * formatted firebase_mocks.dart * removed ignore directive for custom lint rule * formatted login_view_model file * removal of commented code * removed fcmToken test * avoid dynamic calls check passed * format check * fixed linting issue * added documentation for event_queries file * format check

* written test for post_modal.dart * written the missing test * descriptive name to the key * fix failing test * created settings page (#2299) * created settings page * formatted the code * fixed failing tests * resolved requested changes * fixed failing tests * rebased * descriptive name to the key * Select contact test (#2301) * Created Test * Updated Formatting * fixed fetch events bug (#2308) * fixed events fetching bug * fixed failing tests * added comments to event_queries * fixed failing test * Refactor: Decouple ViewModel by Moving UI Logic to View (#2306) * Refactor: Decouple ViewModel by Moving UI Logic to View * refactoring app_settings_view_model and app_seetings_page * writing test for missing lines * fix: Removed all references to Google firebase (#2257) * feature: Removed all references to Google firebase * formatted firebase_mocks.dart * removed ignore directive for custom lint rule * formatted login_view_model file * removal of commented code * removed fcmToken test * avoid dynamic calls check passed * format check * fixed linting issue * added documentation for event_queries file * format check * Bump syncfusion_flutter_datepicker from 24.1.43 to 24.1.44 (#2315) Bumps [syncfusion_flutter_datepicker](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.1.43 to 24.1.44. - [Release notes](https://github.com/syncfusion/flutter-widgets/releases) - [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages) --- updated-dependencies: - dependency-name: syncfusion_flutter_datepicker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump url_launcher_platform_interface from 2.2.0 to 2.3.0 (#2314) Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.0/packages/url_launcher) --- updated-dependencies: - dependency-name: url_launcher_platform_interface dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump image_picker from 1.0.5 to 1.0.6 (#2313) Bumps [image_picker](https://github.com/flutter/packages/tree/main/packages/image_picker) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/image_picker-v1.0.6/packages/image_picker) --- updated-dependencies: - dependency-name: image_picker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump video_player from 2.8.1 to 2.8.2 (#2317) Bumps [video_player](https://github.com/flutter/packages/tree/main/packages/video_player) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/video_player-v2.8.2/packages/video_player) --- updated-dependencies: - dependency-name: video_player dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump google_maps_flutter from 2.5.0 to 2.5.1 (#2316) Bumps [google_maps_flutter](https://github.com/flutter/packages/tree/main/packages/google_maps_flutter) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/google_maps_flutter-v2.5.1/packages/google_maps_flutter) --- updated-dependencies: - dependency-name: google_maps_flutter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * merged develop branch * fix * fix failing test --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Shaik Azad <[email protected]> Co-authored-by: Shivam Gupta <[email protected]> Co-authored-by: Parag Gupta <[email protected]> Co-authored-by: Abhishek Saini <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…2257) * feature: Removed all references to Google firebase * formatted firebase_mocks.dart * removed ignore directive for custom lint rule * formatted login_view_model file * removal of commented code * removed fcmToken test * avoid dynamic calls check passed * format check * fixed linting issue * added documentation for event_queries file * format check

* written test for post_modal.dart * written the missing test * descriptive name to the key * fix failing test * created settings page (PalisadoesFoundation#2299) * created settings page * formatted the code * fixed failing tests * resolved requested changes * fixed failing tests * rebased * descriptive name to the key * Select contact test (PalisadoesFoundation#2301) * Created Test * Updated Formatting * fixed fetch events bug (PalisadoesFoundation#2308) * fixed events fetching bug * fixed failing tests * added comments to event_queries * fixed failing test * Refactor: Decouple ViewModel by Moving UI Logic to View (PalisadoesFoundation#2306) * Refactor: Decouple ViewModel by Moving UI Logic to View * refactoring app_settings_view_model and app_seetings_page * writing test for missing lines * fix: Removed all references to Google firebase (PalisadoesFoundation#2257) * feature: Removed all references to Google firebase * formatted firebase_mocks.dart * removed ignore directive for custom lint rule * formatted login_view_model file * removal of commented code * removed fcmToken test * avoid dynamic calls check passed * format check * fixed linting issue * added documentation for event_queries file * format check * Bump syncfusion_flutter_datepicker from 24.1.43 to 24.1.44 (PalisadoesFoundation#2315) Bumps [syncfusion_flutter_datepicker](https://github.com/syncfusion/flutter-widgets/tree/master/packages) from 24.1.43 to 24.1.44. - [Release notes](https://github.com/syncfusion/flutter-widgets/releases) - [Commits](https://github.com/syncfusion/flutter-widgets/commits/HEAD/packages) --- updated-dependencies: - dependency-name: syncfusion_flutter_datepicker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump url_launcher_platform_interface from 2.2.0 to 2.3.0 (PalisadoesFoundation#2314) Bumps [url_launcher_platform_interface](https://github.com/flutter/packages/tree/main/packages/url_launcher) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/url_launcher_platform_interface-v2.3.0/packages/url_launcher) --- updated-dependencies: - dependency-name: url_launcher_platform_interface dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump image_picker from 1.0.5 to 1.0.6 (PalisadoesFoundation#2313) Bumps [image_picker](https://github.com/flutter/packages/tree/main/packages/image_picker) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/image_picker-v1.0.6/packages/image_picker) --- updated-dependencies: - dependency-name: image_picker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump video_player from 2.8.1 to 2.8.2 (PalisadoesFoundation#2317) Bumps [video_player](https://github.com/flutter/packages/tree/main/packages/video_player) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/video_player-v2.8.2/packages/video_player) --- updated-dependencies: - dependency-name: video_player dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump google_maps_flutter from 2.5.0 to 2.5.1 (PalisadoesFoundation#2316) Bumps [google_maps_flutter](https://github.com/flutter/packages/tree/main/packages/google_maps_flutter) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/google_maps_flutter-v2.5.1/packages/google_maps_flutter) --- updated-dependencies: - dependency-name: google_maps_flutter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * merged develop branch * fix * fix failing test --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Shaik Azad <[email protected]> Co-authored-by: Shivam Gupta <[email protected]> Co-authored-by: Parag Gupta <[email protected]> Co-authored-by: Abhishek Saini <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feature: Removed all references to Google firebase

01f3042

github-actions bot reviewed Dec 18, 2023

View reviewed changes

Abhisheksainii changed the title ~~feature: Removed all references to Google firebase~~ fix: Removed all references to Google firebase Dec 18, 2023

formatted firebase_mocks.dart

5eda051

Abhisheksainii added 2 commits December 18, 2023 22:16

removed ignore directive for custom lint rule

0131bfd

formatted login_view_model file

e661a5b

Kevoniat self-requested a review December 18, 2023 19:15

Kevoniat previously approved these changes Dec 18, 2023

View reviewed changes

literalEval requested changes Dec 19, 2023

View reviewed changes

removal of commented code

84e2feb

Abhisheksainii dismissed Kevoniat’s stale review via 84e2feb December 19, 2023 15:55

Abhisheksainii requested review from literalEval and Kevoniat December 19, 2023 17:29

literalEval requested changes Jan 2, 2024

View reviewed changes

test/utils_tests/queries_test.dart Outdated Show resolved Hide resolved

removed fcmToken test

461979e

Abhisheksainii requested a review from literalEval January 3, 2024 08:18

Abhisheksainii force-pushed the removal/firebase-references branch from d3a768f to 9438a45 Compare January 3, 2024 08:58

Abhisheksainii requested a review from palisadoes as a code owner January 3, 2024 08:58

avoid dynamic calls check passed

f8484d5

Abhisheksainii force-pushed the removal/firebase-references branch from 43b1700 to f8484d5 Compare January 3, 2024 09:05

Merge branch 'develop' into removal/firebase-references

e316fe3

palisadoes removed their request for review January 3, 2024 12:08

Merge branch 'develop' into removal/firebase-references

7ca7c2f

format check

8114a39

fixed linting issue

d2cfffe

palisadoes requested review from Ayush0Chaudhary and DMills27 January 7, 2024 10:04

Abhisheksainii mentioned this pull request Jan 7, 2024

Firebase Options Unsupported in Talawa-API and Talawa-Mobile, Causing Login Issues #2274

Closed

Abhisheksainii added 3 commits January 7, 2024 17:36

added documentation for event_queries file

329ed33

Merge branch 'develop' into removal/firebase-references

58f29bb

format check

f194e95

literalEval approved these changes Jan 7, 2024

View reviewed changes

palisadoes approved these changes Jan 7, 2024

View reviewed changes

palisadoes merged commit 705627f into PalisadoesFoundation:develop Jan 7, 2024
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Removed all references to Google firebase #2257

fix: Removed all references to Google firebase #2257

Abhisheksainii commented Dec 18, 2023 •

edited

Loading

github-actions bot commented Dec 18, 2023

github-actions bot left a comment

Abhisheksainii commented Dec 18, 2023

palisadoes commented Dec 18, 2023

Abhisheksainii commented Dec 19, 2023

Abhisheksainii commented Dec 19, 2023

Cioppolo14 commented Dec 27, 2023

Abhisheksainii commented Dec 27, 2023

Abhisheksainii commented Dec 27, 2023

Abhisheksainii commented Jan 2, 2024

Abhisheksainii commented Jan 2, 2024

codecov bot commented Jan 3, 2024 •

edited

Loading

Abhisheksainii commented Jan 3, 2024

Abhisheksainii commented Jan 4, 2024 •

edited

Loading

palisadoes commented Jan 4, 2024

Abhisheksainii commented Jan 6, 2024

Azad99-9 commented Jan 6, 2024

Abhisheksainii commented Jan 6, 2024 •

edited

Loading

palisadoes commented Jan 7, 2024

literalEval left a comment

fix: Removed all references to Google firebase #2257

fix: Removed all references to Google firebase #2257

Conversation

Abhisheksainii commented Dec 18, 2023 • edited Loading

github-actions bot commented Dec 18, 2023

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

github-actions bot left a comment

Choose a reason for hiding this comment

Abhisheksainii commented Dec 18, 2023

palisadoes commented Dec 18, 2023

Abhisheksainii commented Dec 19, 2023

Abhisheksainii commented Dec 19, 2023

Cioppolo14 commented Dec 27, 2023

Abhisheksainii commented Dec 27, 2023

Abhisheksainii commented Dec 27, 2023

Abhisheksainii commented Jan 2, 2024

Abhisheksainii commented Jan 2, 2024

codecov bot commented Jan 3, 2024 • edited Loading

Codecov Report

Abhisheksainii commented Jan 3, 2024

Abhisheksainii commented Jan 4, 2024 • edited Loading

palisadoes commented Jan 4, 2024

Abhisheksainii commented Jan 6, 2024

Azad99-9 commented Jan 6, 2024

Abhisheksainii commented Jan 6, 2024 • edited Loading

palisadoes commented Jan 7, 2024

literalEval left a comment

Choose a reason for hiding this comment

Abhisheksainii commented Dec 18, 2023 •

edited

Loading

codecov bot commented Jan 3, 2024 •

edited

Loading

Abhisheksainii commented Jan 4, 2024 •

edited

Loading

Abhisheksainii commented Jan 6, 2024 •

edited

Loading