Fixes #2192 #1602 , Improving Filters UI #2245

AyushRaghuvanshi · 2023-12-13T14:09:54Z

What kind of change does this PR introduce?

Feature : Improved the Filter UX and Filter by Date button.

Issue Number:

Fixes #2192 #1602
Did you add tests for your changes?

Its Just refactoring the UI. no tests required

Snapshots/Videos:

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

…into filters

github-actions · 2023-12-13T14:10:21Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

AyushRaghuvanshi · 2023-12-13T14:20:34Z

@noman2002 @palisadoes What do you suggest for the count of lines. I think It requires this much code.

noman2002 · 2023-12-14T05:46:34Z

@noman2002 @palisadoes What do you suggest for the count of lines. I think It requires this much code.

Make components and reduce the number of lines in that particular file.

codecov · 2023-12-14T13:21:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9749844) 88.27% compared to head (15cd4ea) 90.35%.
Report is 8 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2245      +/-   ##
===========================================
+ Coverage    88.27%   90.35%   +2.08%     
===========================================
  Files          155      157       +2     
  Lines         7352     7507     +155     
===========================================
+ Hits          6490     6783     +293     
+ Misses         862      724     -138

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AyushRaghuvanshi · 2023-12-14T13:38:41Z

@noman2002 Can you review please?

lib/views/after_auth_screens/events/event_filter_bottomsheet.dart

literalEval

Add proper spacing/new-lines and improve documentation.

literalEval · 2023-12-25T15:36:50Z

lib/services/navigation_service.dart

@@ -118,6 +126,17 @@ class NavigationService {
    );
  }

+  /// This is used for the quick error of `duration: 2 seconds`.
+  ///
+  /// more_info_if_required


Remove this line. Edit the doc template accordingly.

literalEval · 2023-12-25T15:41:06Z

test/service_tests/navigation_service_test.dart

@@ -232,6 +263,14 @@ class TalawaErrorWidget extends StatelessWidget {
  }
 }

+///Tests Navigation Service.


Fix spacing and new line.

literalEval · 2023-12-25T15:42:00Z

test/view_model_tests/after_auth_view_model_tests/add_post_view_model_test.dart

+///   None
+///
+/// **returns**:
+///   None


You don't need to write documentation for main function. Please read the doc guideline once.

literalEval · 2023-12-25T15:43:26Z

pubspec.lock

-  dart: ">=3.2.0-194.0.dev <3.13.0"
-  flutter: ">=3.13.0"
+  dart: ">=3.2.0 <3.13.0"
+  flutter: ">=3.16.0"


Why is this bump in this PR ?

…into filters

AyushRaghuvanshi · 2023-12-26T16:57:20Z

@literalEval made the changes you requested. Please Review.

literalEval

You don't need to write documentation for test files. Read the doc guideline thoroughly.
Add proper spacing in documentation.

I'd suggest you to take smaller issues for now to get familiar with the codebase and documentation guidelines.

literalEval · 2023-12-27T02:26:01Z

test/service_tests/navigation_service_test.dart

+
+  /// a_line_ending_with_end_punctuation.
+  ///
+  /// more_info_if_required


Fix this doc.

AyushRaghuvanshi · 2023-12-27T07:40:30Z

@literalEval can you point me to the doc where documentations guidelines are written?

What I do is , I go with the custom lint and write documentation for each.

also should I remove all the documentations in test files?

literalEval · 2023-12-27T15:51:49Z

@AyushRaghuvanshi here. Have a look at the official Dart documentation guidelines too.

AyushRaghuvanshi · 2023-12-27T16:43:20Z

@AyushRaghuvanshi here. Have a look at the official Dart documentation guidelines too.

Understood. and have made changes according to that. @literalEval.

literalEval

Use SizeConfig and not constant sizing.

literalEval

Add trailing commas at the end of long lines and reformat.

lib/views/after_auth_screens/events/event_filter_bottomsheet.dart

literalEval · 2023-12-29T12:22:17Z

lib/views/after_auth_screens/events/event_filter_bottomsheet.dart

+                                ? Theme.of(context).colorScheme.secondary
+                                : AppTheme.white,
+                            borderRadius: const BorderRadius.all(
+                              Radius.circular(8),


Use dynamic sizing.

8 here is radius.? do you want me to make this dynamic? I mean it would look weird to make it dependent upon the width or height. Also 8px radius would never cause any overflow error.

I can do it. But I dont think there is any need. Also in whole project we are using constant radius only.

AyushRaghuvanshi · 2023-12-31T12:49:37Z

@literalEval I have made the required changes. Can you review Please?

noman2002

Looks fine.
@literalEval Please have a look.

AyushRaghuvanshi · 2024-01-01T15:50:45Z

@literalEval @palisadoes. I would like to work on More issues and this Pr is actually blocking both of my issues quota. Can you look into this?

… Filters UI (PalisadoesFoundation#2245) * Add:Filters * Add:Documentation * Add:MultiLingual Support * Fix:Format * Reduced: Lines of Codes * Fixed:Tests * Add:Fix Failing test case * Add:Tests for requested lines * Add:test for filter changing * Fixed:changes requested * Add:Changes * Fix:Documentation * Fix:Dart version * Fixed:spacing * Remove: useless docs * Remove:Spaces * Removed:spaces * Fix:Constant Sizes * Fix:Format issues * Minor FIx * Fix:format * Fix:Dynamic size * Fix:Dynamic size * Fix:Failing test * Fix:Failing test

AyushRaghuvanshi added 4 commits December 13, 2023 17:29

Add:Filters

21a6146

Add:Documentation

96d3856

Merge branch 'develop' of https://github.com/AyushRaghuvanshi/talawa …

22b2521

…into filters

Add:MultiLingual Support

ee0dde0

Fix:Format

cb7c7c6

AyushRaghuvanshi added 3 commits December 14, 2023 17:26

Reduced: Lines of Codes

6a32a87

Fixed:Tests

5d5f20c

Add:Fix Failing test case

f6574c9

noman2002 requested changes Dec 15, 2023

View reviewed changes

AyushRaghuvanshi added 2 commits December 24, 2023 00:45

Add:Tests for requested lines

4a9cd99

Add:test for filter changing

63d2dbf

AyushRaghuvanshi requested a review from noman2002 December 23, 2023 19:30

palisadoes requested review from literalEval and Ayush0Chaudhary December 25, 2023 13:42

literalEval requested changes Dec 25, 2023

View reviewed changes

literalEval reviewed Dec 25, 2023

View reviewed changes

AyushRaghuvanshi added 3 commits December 25, 2023 21:28

Fixed:changes requested

ba118f9

Merge branch 'develop' of https://github.com/AyushRaghuvanshi/talawa …

5fe2f38

…into filters

Add:Changes

74a4576

AyushRaghuvanshi requested a review from literalEval December 25, 2023 16:15

literalEval requested changes Dec 27, 2023

View reviewed changes

AyushRaghuvanshi added 2 commits December 27, 2023 14:37

Fix:Documentation

c97b9c3

Fix:Dart version

ffd702a

Fixed:spacing

8c5fb25

AyushRaghuvanshi added 3 commits December 27, 2023 21:57

Remove: useless docs

3aa5821

Remove:Spaces

ac4a4de

Removed:spaces

627d487

AyushRaghuvanshi requested a review from literalEval December 27, 2023 16:43

literalEval requested changes Dec 28, 2023

View reviewed changes

AyushRaghuvanshi added 3 commits December 28, 2023 16:51

Fix:Constant Sizes

a0a2244

Fix:Format issues

8eceaa2

Minor FIx

9c87611

AyushRaghuvanshi requested a review from literalEval December 28, 2023 11:44

literalEval requested changes Dec 29, 2023

View reviewed changes

Fix:format

828b06d

AyushRaghuvanshi requested a review from literalEval December 29, 2023 08:10

literalEval requested changes Dec 29, 2023

View reviewed changes

AyushRaghuvanshi added 4 commits December 29, 2023 18:32

Fix:Dynamic size

2a9b149

Fix:Dynamic size

1cd15c2

Fix:Failing test

9f08e2d

Fix:Failing test

15cd4ea

AyushRaghuvanshi requested a review from literalEval December 29, 2023 15:08

noman2002 approved these changes Dec 31, 2023

View reviewed changes

palisadoes approved these changes Jan 1, 2024

View reviewed changes

palisadoes merged commit 5e3e70e into PalisadoesFoundation:develop Jan 1, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #2192 #1602 , Improving Filters UI #2245

Fixes #2192 #1602 , Improving Filters UI #2245

AyushRaghuvanshi commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

AyushRaghuvanshi commented Dec 13, 2023

noman2002 commented Dec 14, 2023

codecov bot commented Dec 14, 2023 •

edited

Loading

AyushRaghuvanshi commented Dec 14, 2023

literalEval left a comment

literalEval Dec 25, 2023

literalEval Dec 25, 2023

literalEval Dec 25, 2023

literalEval Dec 25, 2023

AyushRaghuvanshi commented Dec 26, 2023

literalEval left a comment

literalEval Dec 27, 2023

AyushRaghuvanshi commented Dec 27, 2023 •

edited

Loading

literalEval commented Dec 27, 2023

AyushRaghuvanshi commented Dec 27, 2023

literalEval left a comment

literalEval left a comment

literalEval Dec 29, 2023

AyushRaghuvanshi Dec 29, 2023

AyushRaghuvanshi commented Dec 31, 2023

noman2002 left a comment

AyushRaghuvanshi commented Jan 1, 2024

Fixes #2192 #1602 , Improving Filters UI #2245

Fixes #2192 #1602 , Improving Filters UI #2245

Conversation

AyushRaghuvanshi commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

AyushRaghuvanshi commented Dec 13, 2023

noman2002 commented Dec 14, 2023

codecov bot commented Dec 14, 2023 • edited Loading

Codecov Report

AyushRaghuvanshi commented Dec 14, 2023

literalEval left a comment

Choose a reason for hiding this comment

literalEval Dec 25, 2023

Choose a reason for hiding this comment

literalEval Dec 25, 2023

Choose a reason for hiding this comment

literalEval Dec 25, 2023

Choose a reason for hiding this comment

literalEval Dec 25, 2023

Choose a reason for hiding this comment

AyushRaghuvanshi commented Dec 26, 2023

literalEval left a comment

Choose a reason for hiding this comment

literalEval Dec 27, 2023

Choose a reason for hiding this comment

AyushRaghuvanshi commented Dec 27, 2023 • edited Loading

literalEval commented Dec 27, 2023

AyushRaghuvanshi commented Dec 27, 2023

literalEval left a comment

Choose a reason for hiding this comment

literalEval left a comment

Choose a reason for hiding this comment

literalEval Dec 29, 2023

Choose a reason for hiding this comment

AyushRaghuvanshi Dec 29, 2023

Choose a reason for hiding this comment

AyushRaghuvanshi commented Dec 31, 2023

noman2002 left a comment

Choose a reason for hiding this comment

AyushRaghuvanshi commented Jan 1, 2024

codecov bot commented Dec 14, 2023 •

edited

Loading

AyushRaghuvanshi commented Dec 27, 2023 •

edited

Loading